refactor: check application emojis first

discordjs · Sep 5, 2024 · 7f24d38 · 7f24d38
1 parent 6f25ce8
commit 7f24d38
Showing 1 changed file with 6 additions and 7 deletions.
diff --git a/packages/discord.js/src/structures/MessageReaction.js b/packages/discord.js/src/structures/MessageReaction.js
@@ -121,18 +121,17 @@ class MessageReaction {
     if (this._emoji instanceof ApplicationEmoji) return this._emoji;
     // Check to see if the emoji has become known to the client
     if (this._emoji.id) {
+      const applicationEmojis = this.message.client.application.emojis.cache;
+      if (applicationEmojis.has(this._emoji.id)) {
+        const emoji = applicationEmojis.get(this._emoji.id);
+        this._emoji = emoji;
+        return emoji;
+      }
       const emojis = this.message.client.emojis.cache;
       if (emojis.has(this._emoji.id)) {
         const emoji = emojis.get(this._emoji.id);
         this._emoji = emoji;
         return emoji;
-      } else {
-        const applicationEmojis = this.message.client.application.emojis.cache;
-        if (applicationEmojis.has(this._emoji.id)) {
-          const emoji = applicationEmojis.get(this._emoji.id);
-          this._emoji = emoji;
-          return emoji;
-        }
       }
     }
     return this._emoji;