Presence on User

[almostSouji]

Is there any good reason why we apply Presence back to the User instance? Presences are intrinsically guild bound data, yet we apply it back to the underlying User.

In day to day support, this has often caused issues to arise where the presence is not available on the User but works flawlessly if accessed via the GuildMember instance (message.author being but one example).

[MattIPv4]

Seems it is just a glorified helper getter to get the presence from the first guild that has the presence.

discord.js/src/structures/User.js

Lines 141 to 153 in f95f5dc

	/**
	* The presence of this user
	* @type {Presence}
	* @readonly
	*/
	get presence() {
	for (const guild of this.client.guilds.cache.values()) {
	if (guild.presences.cache.has(this.id)) return guild.presences.cache.get(this.id);
	}
	if (!Structures) Structures = require('../util/Structures');
	const Presence = Structures.get('Presence');
	return new Presence(this.client, { user: { id: this.id } });
	}

Seems like a sensible bit of cruft to remove given it causes confusion and is nothing more than a helper, no unique data stored.