Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invert deletable message types list #10093

Merged
merged 3 commits into from
Feb 3, 2024
Merged

Conversation

almeidx
Copy link
Member

@almeidx almeidx commented Jan 17, 2024

Please describe the changes this PR makes and why it should be merged:
Discord has inverted their deletable message types list to be an undeletable message types list instead:

Replicated this on our side and deprecated the previous DeletableMessageTypes array.

Status and versioning classification:

  • I know how to update typings and have done so, or typings don't need updating

@almeidx almeidx requested a review from a team as a code owner January 17, 2024 12:02
Copy link

vercel bot commented Jan 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2024 9:47pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Feb 3, 2024 9:47pm

packages/discord.js/typings/index.d.ts Outdated Show resolved Hide resolved
Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
Copy link

codecov bot commented Feb 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f691658) 58.53% compared to head (d4292c8) 58.57%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10093      +/-   ##
==========================================
+ Coverage   58.53%   58.57%   +0.03%     
==========================================
  Files         244      244              
  Lines       17267    17309      +42     
  Branches     1244     1250       +6     
==========================================
+ Hits        10107    10138      +31     
- Misses       7115     7126      +11     
  Partials       45       45              
Flag Coverage Δ
builders 95.56% <ø> (ø)
next ∅ <ø> (∅)
proxy 75.00% <ø> (ø)
rest 92.58% <ø> (-0.33%) ⬇️
website 0.00% <ø> (ø)
ws 52.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kodiakhq kodiakhq bot merged commit 42bc5d2 into main Feb 3, 2024
23 checks passed
@kodiakhq kodiakhq bot deleted the fix/undeletable-message-types branch February 3, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants