Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: convert comment into private remark #10097

Merged
merged 2 commits into from
Jan 22, 2024
Merged

docs: convert comment into private remark #10097

merged 2 commits into from
Jan 22, 2024

Conversation

almeidx
Copy link
Member

@almeidx almeidx commented Jan 22, 2024

Please describe the changes this PR makes and why it should be merged:
The return type currently shows like this in the new documentation site:
image

Converted the comment into @privateRemarks to work around it

Status and versioning classification:

  • This PR only includes non-code changes, like changes to documentation, README, etc.

@almeidx almeidx requested a review from a team as a code owner January 22, 2024 13:52
@vercel Vercel
Copy link

vercel bot commented Jan 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2024 6:44pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2024 6:44pm

@Jiralite Jiralite added this to the discord.js 14.15 milestone Jan 22, 2024
@kodiakhq kodiakhq bot merged commit bfc7bb5 into main Jan 22, 2024
7 checks passed
@kodiakhq kodiakhq bot deleted the docs/convert-comment-to-private-remark branch January 22, 2024 18:45
@whizbangpop whizbangpop mentioned this pull request May 25, 2024
Open
@lockyz lockyz mentioned this pull request May 25, 2024
Closed
@HowlingArcher HowlingArcher mentioned this pull request May 25, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request May 25, 2024
Open
@WhyAydan WhyAydan mentioned this pull request May 26, 2024
Open
@User5029 User5029 mentioned this pull request May 26, 2024
Open
@StrezlessMusick StrezlessMusick mentioned this pull request May 26, 2024
Open
@The0mikkel The0mikkel mentioned this pull request May 26, 2024
Closed
@Azzraya Azzraya mentioned this pull request May 26, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request May 26, 2024
Open
@User5029 User5029 mentioned this pull request May 26, 2024
Open
@AzhamProdLive AzhamProdLive mentioned this pull request May 26, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request May 26, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 19, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Aug 19, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 19, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Aug 20, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 20, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Aug 20, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 20, 2024
Open
@Jcrandall541 Jcrandall541 mentioned this pull request Aug 21, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Aug 21, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 21, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Aug 21, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 21, 2024
Open
@Jcrandall541 Jcrandall541 mentioned this pull request Aug 22, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Aug 22, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Aug 22, 2024
Open
@whizbangpop whizbangpop mentioned this pull request Aug 22, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 22, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 22, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Aug 28, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 28, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 28, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Aug 29, 2024
Open
This was referenced Aug 30, 2024
Open
Open
@jshuntley jshuntley mentioned this pull request Sep 1, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Sep 2, 2024
Open
@jshuntley jshuntley mentioned this pull request Sep 2, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Sep 2, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Sep 2, 2024
Open
@Azzraya Azzraya mentioned this pull request Sep 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyranet kyranet kyranet approved these changes

@didinele didinele didinele approved these changes

@Jiralite Jiralite Jiralite approved these changes

@vladfrangu vladfrangu Awaiting requested review from vladfrangu vladfrangu is a code owner automatically assigned from discordjs/core

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

Assignees
No one assigned
Labels
documentation packages:discord.js semver:patch
Projects
discord.js
Archived in project
Milestone
discord.js 14.15
Development

Successfully merging this pull request may close these issues.
4 participants
@almeidx @kyranet @didinele @Jiralite