Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: generic for Webhook type #10188

Merged
merged 4 commits into from
Mar 31, 2024
Merged

types: generic for Webhook type #10188

merged 4 commits into from
Mar 31, 2024

Conversation

Qjuh
Copy link
Contributor

@Qjuh Qjuh commented Mar 23, 2024

Please describe the changes this PR makes and why it should be merged:

Introduce a type parameter Webhook<Type extends WebhookType> that determines the type of Webhook to correclty narrow its properties. The typeguard methods of Webhook now use this type parameter.

Resolves #9182

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@Qjuh Qjuh requested a review from a team as a code owner March 23, 2024 12:48
Copy link

vercel bot commented Mar 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Mar 31, 2024 2:10pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Mar 31, 2024 2:10pm

@kodiakhq kodiakhq bot merged commit 980a2b7 into discordjs:main Mar 31, 2024
6 checks passed
@Qjuh Qjuh deleted the types/webhook branch April 15, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

typings(webhooks): Incoming webhook
5 participants