-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(GuildChannelManager): Remove redundant edit code #10370
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10370 +/- ##
==========================================
+ Coverage 50.38% 50.52% +0.14%
==========================================
Files 228 228
Lines 20633 20705 +72
Branches 1236 1252 +16
==========================================
+ Hits 10396 10462 +66
- Misses 10193 10199 +6
Partials 44 44
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Please describe the changes this PR makes and why it should be merged:
Removes redundant code, such as this:
In this example,
.trim()
is redundant as the API performs trimming. The??
is also redundant (here and later in the code) as the properties are optional. Methods like these work just fine still:Also avoided reassigning the parameter.
Status and versioning classification: