feat: Add support for Automated Message nonce handling #10381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Jiralite
requested changes
Jul 9, 2024
packages/discord.js/src/structures/interfaces/TextBasedChannel.js
Outdated
Show resolved
Hide resolved
JMTK
changed the title
JMTK
changed the title
Jiralite
previously requested changes
Jul 10, 2024
packages/discord.js/src/structures/interfaces/TextBasedChannel.js
Outdated
Show resolved
Hide resolved
…to not generate a nonce, and PR feedback
almeidx
previously requested changes
Jul 13, 2024
packages/discord.js/src/structures/interfaces/TextBasedChannel.js
Outdated
Show resolved
Hide resolved
almeidx
reviewed
Jul 15, 2024
Co-authored-by: Almeida <github@almeidx.dev>
vladfrangu
previously requested changes
Jul 16, 2024
nyapat
pushed a commit
to nyapat/discord.js
that referenced
this pull request
Oct 4, 2024
* Add support for Automated Message nonce handling * Fix options property * Address PR feedback * Handled case where it was explicitly set to false for that iteration to not generate a nonce, and PR feedback * Fix lint issue * Fix lint issue * Move to MessagePayload.resolveBody instead * Fix test errors * Update packages/discord.js/src/structures/MessagePayload.js Co-authored-by: Almeida <github@almeidx.dev> * PR feedback * Merge * Let and not const --------- Co-authored-by: Almeida <github@almeidx.dev> Co-authored-by: Almeida <almeidx@pm.me>
nyapat
pushed a commit
to nyapat/discord.js
that referenced
this pull request
Oct 4, 2024
* build: bump discord-api-types to 0.37.95 * feat: Add support for Automated Message nonce handling (discordjs#10381) * Add support for Automated Message nonce handling * Fix options property * Address PR feedback * Handled case where it was explicitly set to false for that iteration to not generate a nonce, and PR feedback * Fix lint issue * Fix lint issue * Move to MessagePayload.resolveBody instead * Fix test errors * Update packages/discord.js/src/structures/MessagePayload.js Co-authored-by: Almeida <github@almeidx.dev> * PR feedback * Merge * Let and not const --------- Co-authored-by: Almeida <github@almeidx.dev> Co-authored-by: Almeida <almeidx@pm.me> * feat(Attachment): add `title` (discordjs#10423) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * types: Fix wrong auto moderation target type (discordjs#10391) types: fix wrong auto moderation target type Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * feat(builders): update to @sapphire/shapeshift v4 (discordjs#10291) feat: update to @sapphire/shapeshift v4 * refactor(actions): safer getChannel calls (discordjs#10434) * refactor(actions): safer getChannel calls * chore: consistency --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * build: bump discord-api-types tp 0.37.96 --------- Co-authored-by: Jacob Morrison <jake.morrison24@gmail.com> Co-authored-by: Almeida <github@almeidx.dev> Co-authored-by: Almeida <almeidx@pm.me> Co-authored-by: Danial Raza <danialrazafb@gmail.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com> Co-authored-by: Jeroen Claassens <support@favware.tech> Co-authored-by: DD <didinele.dev@gmail.com>
This was referenced Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Took a stab at doing this, let me know if there's any issues! Fixes #10323
Only thing I thought about was to instead make this a function you can pass in to generate nonces, so something like
But the users may run into issues, such as the 25 character limit, generating high collision nonces, etc
Status and versioning classification:
Minor