fix(Shard): add env, execArgv, and argv for worker-based shards #10429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
catplvsplus
changed the title
almeidx
previously requested changes
Aug 4, 2024
There was a problem hiding this comment.
These doc comments need updating
discord.js/packages/discord.js/src/sharding/Shard.js
Lines 51 to 61 in f623e7a
Qjuh
reviewed
Aug 4, 2024
SpaceEEC
approved these changes
Aug 19, 2024
kyranet
approved these changes
Aug 20, 2024
vladfrangu
approved these changes
Aug 20, 2024
nyapat
pushed a commit
to nyapat/discord.js
that referenced
this pull request
Sep 9, 2024
…ordjs#10429) * fix(Shard): add env, execArgv, and argv to worker-based threads * chore: remove process only docs assertion from certain shard options * chore: update comments for Shard.js * refactor: Use SHARE_ENV for worker shard's env * chore: import order --------- Co-authored-by: Cat++ <69035887+NotGhex@users.noreply.github.com>
nyapat
pushed a commit
to nyapat/discord.js
that referenced
this pull request
Oct 4, 2024
…ordjs#10429) * fix(Shard): add env, execArgv, and argv to worker-based threads * chore: remove process only docs assertion from certain shard options * chore: update comments for Shard.js * refactor: Use SHARE_ENV for worker shard's env * chore: import order --------- Co-authored-by: Cat++ <69035887+NotGhex@users.noreply.github.com>
This was referenced Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Adds
env,execArgv,argvto worker thread creation options. This allows theShardingManagerOptions#execArgv,ShardingManagerOptions#shardArgsandShard#envto be used not only by the child-process based shards.Status and versioning classification: