Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use get guild role endpoint #10443

Merged
merged 4 commits into from
Aug 21, 2024
Merged

refactor: use get guild role endpoint #10443

merged 4 commits into from
Aug 21, 2024

Conversation

almeidx
Copy link
Member

@almeidx almeidx commented Aug 14, 2024

Please describe the changes this PR makes and why it should be merged:
Makes use of the new Get Guild Role endpoint on RoleManager#fetch(id) and added a getRole() method on GuildsAPI

Upstream:

Depends on:

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@almeidx almeidx requested a review from a team as a code owner August 14, 2024 18:20
Copy link

vercel bot commented Aug 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Aug 21, 2024 10:10pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Aug 21, 2024 10:10pm

@almeidx almeidx force-pushed the feat/get-guild-role branch from b44318c to b0326ac Compare August 14, 2024 18:21
@almeidx almeidx marked this pull request as draft August 14, 2024 18:25
@almeidx almeidx marked this pull request as ready for review August 20, 2024 09:40
@kodiakhq kodiakhq bot merged commit bba0e72 into main Aug 21, 2024
8 checks passed
@kodiakhq kodiakhq bot deleted the feat/get-guild-role branch August 21, 2024 22:14
nyapat pushed a commit to nyapat/discord.js that referenced this pull request Sep 9, 2024
* refactor: use get guild role endpoint

* style: import order

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
nyapat pushed a commit to nyapat/discord.js that referenced this pull request Oct 4, 2024
* refactor: use get guild role endpoint

* style: import order

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants