-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: type guard for sendable text-based channels #10482
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
IG this (and the JSDoc) can also be updated to include PartialGroupDMChannel since it's considered text-based now discord.js/packages/discord.js/src/util/Constants.js Lines 96 to 122 in 4594896
|
Qjuh
suggested changes
Sep 4, 2024
Qjuh
reviewed
Sep 4, 2024
Co-authored-by: Qjuh <76154676+Qjuh@users.noreply.github.com>
Qjuh
approved these changes
Sep 4, 2024
Jiralite
changed the title
fix: type-guard for sendable text-based channels
fix: type guard for sendable text-based channels
Sep 4, 2024
Jiralite
approved these changes
Sep 4, 2024
didinele
approved these changes
Sep 5, 2024
SpaceEEC
approved these changes
Sep 5, 2024
Qjuh
approved these changes
Sep 6, 2024
nyapat
pushed a commit
to nyapat/discord.js
that referenced
this pull request
Oct 4, 2024
* fix: type-guard for sendable text-based channels * chore: suggested change * Update packages/discord.js/typings/index.test-d.ts Co-authored-by: Qjuh <76154676+Qjuh@users.noreply.github.com> * fix: make isSendable strictly check for `.send` * fix: tests --------- Co-authored-by: Qjuh <76154676+Qjuh@users.noreply.github.com> Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
This was referenced Oct 13, 2024
This was referenced Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Adds in
BaseChannel#isSendable
, which is a mix ofisTextBased()
and checking if you can actually send messages in the channel. This way, we can have the correct types for interaction.channel, and you can assert whether you got the interaction from a Group DM Channel or notStatus and versioning classification: