Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add subscriptions #10486

Merged
merged 3 commits into from
Nov 4, 2024
Merged

Conversation

sdanialraza
Copy link
Contributor

@sdanialraza sdanialraza commented Sep 5, 2024

Please describe the changes this PR makes and why it should be merged:
Adds subscriptions for core

Depends on changes from:

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

Copy link

vercel bot commented Sep 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 4, 2024 10:46am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Nov 4, 2024 10:46am

packages/core/src/api/monetization.ts Outdated Show resolved Hide resolved
packages/core/src/api/monetization.ts Outdated Show resolved Hide resolved
Copy link
Member

@almeidx almeidx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sdanialraza sdanialraza force-pushed the feat/add-subscriptions branch 2 times, most recently from f1d9754 to a27479f Compare October 3, 2024 17:31
packages/core/src/api/monetization.ts Outdated Show resolved Hide resolved
packages/core/src/api/monetization.ts Outdated Show resolved Hide resolved
Co-authored-by: Almeida <github@almeidx.dev>
@kodiakhq kodiakhq bot merged commit 1fd6626 into discordjs:main Nov 4, 2024
7 checks passed
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.15%. Comparing base (ed78e45) to head (f95b6d9).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10486      +/-   ##
==========================================
- Coverage   38.01%   35.15%   -2.86%     
==========================================
  Files         239      240       +1     
  Lines       15471    14523     -948     
  Branches     1353     1200     -153     
==========================================
- Hits         5881     5106     -775     
+ Misses       9575     9370     -205     
- Partials       15       47      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sdanialraza sdanialraza deleted the feat/add-subscriptions branch November 5, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants