Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Client): fix incorrect managers descriptions #10519

Merged
merged 3 commits into from
Oct 11, 2024

Conversation

Wolvinny
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
Some managers had incorrect descriptions, which applied only to the cache of the manager

  • This PR only includes non-code changes, like changes to documentation, README, etc.

@Wolvinny Wolvinny requested a review from a team as a code owner September 25, 2024 13:17
Copy link

vercel bot commented Sep 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Oct 11, 2024 8:48pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Oct 11, 2024 8:48pm

@Wolvinny Wolvinny changed the title Fix manager's incorrect description docs: Fix manager's incorrect description Sep 25, 2024
@Wolvinny Wolvinny changed the title docs: Fix manager's incorrect description docs: fix manager's incorrect description Sep 25, 2024
Copy link

@benjGam benjGam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems better like that.

@Jiralite Jiralite added this to the discord.js 14.17 milestone Oct 1, 2024
@Jiralite Jiralite changed the title docs: fix manager's incorrect description docs(Client): fix incorrect managers description Oct 1, 2024
@Jiralite Jiralite changed the title docs(Client): fix incorrect managers description docs(Client): fix incorrect managers descriptions Oct 1, 2024
Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

@didinele
Copy link
Member

This needs a rebase

Some managers had incorrect descriptions, which applied only to the cache of the manager
@kodiakhq kodiakhq bot merged commit eded459 into discordjs:main Oct 11, 2024
7 checks passed
almeidx added a commit that referenced this pull request Oct 11, 2024
@almeidx almeidx mentioned this pull request Oct 11, 2024
vladfrangu pushed a commit that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants