feat!: add ChannelManager#createMessage()

[TAEMBO]

Please describe the changes this PR makes and why it should be merged:
Adds a centralized spot where the creation of messages go through.

BREAKING CHANGE: MessageCreateOptions no longer accepts reply. Use messageReference instead.

Status and versioning classification:

• Code changes have been tested against the Discord API, or there are no code changes
• I know how to update typings and have done so, or typings don't need updating
• This PR changes the library's interface (methods or parameters added)
• This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
discord-js	⬜️ Ignored (Inspect)	Visit Preview		Jan 14, 2025 6:12am
discord-js-guide	⬜️ Ignored (Inspect)	Visit Preview		Jan 14, 2025 6:12am

[Jiralite]

This is missing an implementation in send(). Just like reply is an option there, there should be a forward option.

Although, now that both reply and forward is there, maybe both should be removed in favour of messageReference so we don't have to keep adding new message reference types (and thus new properties).

Stale.

[vladfrangu]

I'm a huge fan of client.channels.createMessage, but not a fan of removing TextBasedChannel#send / Message#reply. Let's please keep those in and redirect to the manager function

[vladfrangu]

Aren't this still valid now?

[TAEMBO]

No, because the target when sending a DM is now ChannelManager rather than a User or GuildMember. User#send() and GuildMember#send() now resolve the DM channel and call ChannelManager#createMessage() as opposed to using TextBasedChannel#send() and having that resolve the DM channel from the target.

[GabuTheDev]

Hello! Not an expert here, but since this PR implements message#forward, the behavior of message#editable and message#edit should also be updated, as forwarded messages cannot be edited.

[SpaceEEC]

Target must (currently?) be something with a client, which a string isn't.
e.g. this.target.client.options.failIfNotExists would throw an error.

[TAEMBO]

The channel ID isn't used as the target though. When using ChannelManager#createMessage(), the ChannelManager is the target, which does have a client property.

https://github.com/discordjs/discord.js/pull/10559/files#diff-0df9d32ad690588a2c0666ab3aeb1f592ab7dc3e27e6161442a3d048d83646cbR166

[TAEMBO]

Hello! Not an expert here, but since this PR implements message#forward, the behavior of message#editable and message#edit should also be updated, as forwarded messages cannot be edited.

@GabuTheDev I think updating Message#editable to reflect this limitation is a good idea, however I disagree about updating Message#edit(). That method does not have any existing checks within it as Message#editable exists to serve that purpose.