Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(InteractionResponses)!: Remove ephemeral response option #10564

Merged
merged 3 commits into from
Oct 22, 2024
Merged

refactor(InteractionResponses)!: Remove ephemeral response option #10564

merged 3 commits into from
Oct 22, 2024
+28 −36

Conversation

Jiralite
Copy link
Member

@Jiralite Jiralite commented Oct 17, 2024 •
edited
Loading

Please describe the changes this PR makes and why it should be merged:
The ephemeral option in these responses are redundant as flags exists.

BREAKING CHANGE: MessagePayload#isInteraction no longer serves a purpose and has been removed.
BREAKING CHANGE: InteractionDeferReplyOptions no longer accepts ephemeral. Use flags instead.
BREAKING CHANGE: InteractionReplyOptions no longer accepts ephemeral. Use flags instead.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

@Jiralite Jiralite added this to the discord.js 15.0.0 milestone Oct 17, 2024
@Jiralite Jiralite requested a review from a team as a code owner October 17, 2024 20:09
@vercel Vercel
Copy link

vercel bot commented Oct 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 4:51am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Oct 22, 2024 4:51am

@Jiralite Jiralite changed the title refactor(InteractionResponses): Remove ephemeral response option refactor(InteractionResponses)!: Remove ephemeral response option Oct 17, 2024
@didinele didinele merged commit 48a9c66 into main Oct 22, 2024
8 checks passed
@didinele didinele deleted the refactor/remove-ephemeral branch October 22, 2024 06:10
@Jiralite Jiralite mentioned this pull request Oct 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@didinele didinele didinele approved these changes

@kyranet kyranet kyranet approved these changes

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

Assignees
No one assigned
Labels
packages:discord.js semver:major
Projects
discord.js
Archived in project
Milestone
discord.js 15.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Jiralite @vladfrangu @kyranet @didinele