Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct guild member banner URL #10677

Merged
merged 2 commits into from
Jan 2, 2025
Merged

fix: Correct guild member banner URL #10677

merged 2 commits into from
Jan 2, 2025

Conversation

Jiralite
Copy link
Member

@Jiralite Jiralite commented Jan 2, 2025

Please describe the changes this PR makes and why it should be merged:
See https://discord.com/developers/docs/reference#image-formatting-cdn-endpoints.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@Jiralite Jiralite requested a review from a team as a code owner January 2, 2025 00:50
Copy link

vercel bot commented Jan 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Jan 2, 2025 8:15am
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Jan 2, 2025 8:15am

@Jiralite Jiralite added this to the rest 3.0.0 milestone Jan 2, 2025
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.96%. Comparing base (65883f3) to head (f8706e0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10677      +/-   ##
==========================================
+ Coverage   37.91%   37.96%   +0.04%     
==========================================
  Files         239      239              
  Lines       14877    14877              
  Branches     1376     1377       +1     
==========================================
+ Hits         5641     5648       +7     
+ Misses       9225     9218       -7     
  Partials       11       11              
Flag Coverage Δ
proxy 64.63% <ø> (ø)
rest 87.47% <100.00%> (+0.66%) ⬆️
ws 34.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kodiakhq kodiakhq bot merged commit 9fea069 into main Jan 2, 2025
25 checks passed
@kodiakhq kodiakhq bot deleted the fix/gm-banner branch January 2, 2025 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants