Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types!: remove GuildMemberResolvable #10713

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Conversation

almeidx
Copy link
Member

@almeidx almeidx commented Jan 19, 2025

BREAKING CHANGE: The GuildMemberResolvable union has been removed. Use UserResolvable instead.

The GuildMemberResolvable union was defined as GuildMember | UserResolvable, however, the UserResolvable union already includes GuildMember.

export type GuildMemberResolvable = GuildMember | UserResolvable;

export type UserResolvable = User | Snowflake | Message | GuildMember | ThreadMember;

@almeidx almeidx requested a review from a team as a code owner January 19, 2025 16:05
Copy link

vercel bot commented Jan 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Jan 24, 2025 0:32am
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Jan 24, 2025 0:32am

@almeidx almeidx changed the title docs: remove GuildMemberResolvable types: remove GuildMemberResolvable Jan 19, 2025
@almeidx almeidx changed the title types: remove GuildMemberResolvable types!: remove GuildMemberResolvable Jan 19, 2025
BREAKING CHANGE: The `GuildMemberResolvable` union has been removed. Use `UserResolvable` instead.
@almeidx almeidx force-pushed the docs/remove-guild-member-resolvable branch from eb8fb96 to 4875e9c Compare January 19, 2025 16:20
@almeidx almeidx added this to the discord.js 15.0.0 milestone Jan 19, 2025
@almeidx almeidx merged commit 2cbf418 into main Jan 24, 2025
8 checks passed
@almeidx almeidx deleted the docs/remove-guild-member-resolvable branch January 24, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants