-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(Channels): fix incorrectly shared properties #6262
Conversation
Should probably link #4831 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GuildChannel#setTopic moved to BaseGuildTextChannel
Stage channels would receive this method from BaseGuildVoiceChannel
which extends GuildChannel
, which means this would be lost and needs implementing back in somewhere...
Perhaps just stick it in the stage channel itself? That way, we could customise the description of it as it's a unique case for a stage channel?
Stage channel topics seem to have no purpose at this point. The api accepts and sends topic on stage channels, but it doesn't exist in the UI. I suspect this is a remnant after moving to stage instances. But, it probably should be added back directly. |
Is it still documented that it can be used in a stage channel? I see only text channels and announcement channels here upon editing a channel, which is how it is currently called! Despite the API accepting it, if it does nothing and doesn't seem to be documented... probably best to not add it back in, since stage instances are the way to go right now? |
If its undocumented, lets yeet it. |
This needs a rebase. |
a5604a5
to
2941526
Compare
This addresses a number of issues with various channel properties being defined too generically, resulting in them existing on channel subclasses where they aren't supported by the API.
Changes
Status and versioning classification: