-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
types: fix regressions #7649
types: fix regressions #7649
Conversation
84804e6
to
23dc7aa
Compare
Can you fix this too?
Should be And the discord.js/packages/discord.js/src/util/Components.js Lines 71 to 80 in 549716e
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make tests for this and make sure it works with the suggested changes? 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
da3dfda
to
443c956
Compare
Rebased and pushed a new commit that fixes a bug in the MessagePayload class that wouldn't allow for objects to be mixed with builder classes |
5273df8
to
01a5896
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small request, but doesn't block merge
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
507ae60
to
0fbbe66
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>
Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>
0fbbe66
to
c0f9cd0
Compare
Any news for this ? |
Looks to me That it's ready to go |
Please describe the changes this PR makes and why it should be merged:
This PR fixes a bunch of regressions and missed changes from #7584
Status and versioning classification: