feat(Emoji): create `getURL()` function to get more extension of emoji #8493

dager-mohamed · 2022-08-15T03:28:16Z

Please describe the changes this PR makes and why it should be merged:

discordjs support only .gif and .png for emoji extension, so I created the getURL(ext) function to make the user get any extension of emoji he wants.

Status and versioning classification:

Please move lines that apply to you out of the comment:

Code changes have been tested against the Discord API, or there are no code changes
I know how to update typings and have done so, or typings don't need updating
This PR changes the library's interface (methods or parameters added)

vercel · 2022-08-15T03:28:21Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Updated
discord-js	⬜️ Ignored (Inspect)		Aug 15, 2022 at 3:25PM (UTC)

manuelvleeuwen

I'm not so sure about this one. This breaks consistency with other url getters in the library, and if users want to have another extension, they can use client.rest.cdn.emoji(emoji.id, 'jpg') for example. This function is a shortcut for that, but it breaks consistency, so I don't think it should be added like this.

packages/discord.js/src/structures/Emoji.js

jaw0r3k · 2022-08-15T12:45:31Z

I agree with thehackerboi that .url should be a getter
So making function like getUrl would be better

dager-mohamed · 2022-08-15T12:54:33Z

I agree with thehackerboi that .url should be a getter So making a function like getUrl would be better

so I have an idea and I don't know if this idea is like you said or not,

I can create getUrl(URL) as you said function inside the class to check the URL of the emoji and then return the extension,
and I will use the getUrl() function inside url() and it will be getter that you mean?

I hope that you mean.

jaw0r3k · 2022-08-15T13:01:44Z

Nah i just mean getURL(ext) which will return a url
and leave url as getter ( like everywhere else )

dager-mohamed · 2022-08-15T13:09:01Z

ahaa ok i understand now, i will do it

Co-authored-by: Hackerboi 69 <62872992+thehackerboi69github@users.noreply.github.com>

dager-mohamed · 2022-08-15T15:28:05Z

note: the rest.cdn is automatically throw the error at all

codecov · 2022-08-15T16:32:13Z

Codecov Report

Merging #8493 (d0aaca6) into main (cb85686) will decrease coverage by 13.45%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##              main    #8493       +/-   ##
============================================
- Coverage   100.00%   86.54%   -13.46%     
============================================
  Files            2       87       +85     
  Lines          843     9250     +8407     
  Branches       159     1854     +1695     
============================================
+ Hits           843     8005     +7162     
- Misses           0     1189     +1189     
- Partials         0       56       +56

Flag	Coverage Δ
builders	`100.00% <ø> (?)`
collection	`100.00% <ø> (ø)`
proxy	`83.45% <ø> (?)`
rest	`94.90% <ø> (?)`
utilities	`100.00% <ø> (ø)`
voice	`64.29% <50.00%> (?)`
ws	`63.60% <ø> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
packages/voice/src/audio/AudioPlayerError.ts	`0.00% <0.00%> (ø)`
packages/voice/src/audio/AudioResource.ts	`95.60% <ø> (ø)`
packages/voice/src/joinVoiceChannel.ts	`100.00% <ø> (ø)`
packages/voice/src/networking/Networking.ts	`3.42% <ø> (ø)`
packages/voice/src/VoiceConnection.ts	`81.14% <100.00%> (ø)`
packages/actions/src/formatTag/formatTag.ts	`100.00% <0.00%> (ø)`
packages/voice/src/receive/SSRCMap.ts	`86.66% <0.00%> (ø)`
...src/interactions/contextMenuCommands/Assertions.ts	`100.00% <0.00%> (ø)`
packages/voice/src/receive/SpeakingMap.ts	`100.00% <0.00%> (ø)`
... and 81 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

NotSugden · 2022-10-11T01:03:17Z

packages/discord.js/src/structures/Emoji.js

+  /**
+   * @type {?string}
+   * @param {ImageExtension} ext the extension of emoji
+   * @returns {string}
+   */
+  getURL(ext) {
+    return this.id && this.client.rest.cdn.emoji(this.id, ext);
+  }


i think the position of this function needs to be below all of the getter methods

Suggested change

/**

* @type {?string}

* @param {ImageExtension} ext the extension of emoji

* @returns {string}

*/

getURL(ext) {

return this.id && this.client.rest.cdn.emoji(this.id, ext);

}

/**

* @param {ImageExtension} ext the extension of emoji

* @returns {?string}

*/

getURL(ext) {

return this.id && this.client.rest.cdn.emoji(this.id, ext);

}

also corrected documentation

Suggested change

/**

* @type {?string}

* @param {ImageExtension} ext the extension of emoji

* @returns {string}

*/

getURL(ext) {

return this.id && this.client.rest.cdn.emoji(this.id, ext);

}

/**

* Returns an emoji url with the specified extension

* @param {ImageExtension} ext The extension of the emoji

* @returns {?string}

*/

getURL(ext) {

return this.id && this.client.rest.cdn.emoji(this.id, ext);

}

NotSugden · 2022-10-11T01:04:01Z

packages/discord.js/typings/index.d.ts

@@ -1070,6 +1070,7 @@ export class Emoji extends Base {
  public name: string | null;
  public get identifier(): string;
  public get url(): string | null;
+  public getURL(ext: ImageExtension): string;


Suggested change

public getURL(ext: ImageExtension): string;

public getURL(ext: ImageExtension): string | null;

as per previous suggestion the method can return null

Jiralite · 2023-08-20T15:32:23Z

Superseded by #9788.

dager-mohamed and others added 13 commits August 10, 2022 17:10

Update MessageDelete.js

049f84a

Update MessageDelete.js

43256db

Merge branch 'main' into main

80aaa27

Merge branch 'main' of https://github.com/dager-mohamed/discord.js

4b8722d

Merge branch 'discordjs:main' into main

37f5252

feat(AddEmoji): support more extentions in url()

2388a85

Update Emoji.js

ec1eb4d

Merge branch 'discordjs:main' into main

db47e9e

Update MessageDelete.js

ca4d45a

feat(Emoji): support more extentions in url()

21b41da

support ext 2

6bcafc0

Create emoji.js

88e92cd

Update index.d.ts

a06ce58

github-actions bot added the packages:discord.js label Aug 15, 2022

github-actions bot requested review from iCrawl, kyranet, SpaceEEC and vladfrangu August 15, 2022 03:28

Update index.d.ts

fecbaba

manuelvleeuwen suggested changes Aug 15, 2022

View reviewed changes

packages/discord.js/src/structures/Emoji.js Outdated Show resolved Hide resolved

dager-mohamed added 2 commits August 15, 2022 14:05

Update Emoji.js

6e78184

Update emoji.js

5c7b085

dager-mohamed added 3 commits August 15, 2022 15:17

getUrl(ext) function added and url is getter

66a9eea

Update index.d.ts

18e9b16

Update emoji.js

aa1c4b6

dager-mohamed and others added 3 commits August 15, 2022 16:44

Update packages/discord.js/typings/index.d.ts

e1d2169

Co-authored-by: Hackerboi 69 <62872992+thehackerboi69github@users.noreply.github.com>

Update Emoji.js

2b320ef

Update emoji.js

d0aaca6

dager-mohamed requested review from Syjalo and manuelvleeuwen and removed request for Syjalo August 15, 2022 15:25

manuelvleeuwen approved these changes Aug 15, 2022

View reviewed changes

dager-mohamed requested a review from Syjalo August 15, 2022 17:26

Jiralite added the blocked label Aug 15, 2022

Jiralite added this to the discord.js v14.3 milestone Aug 15, 2022

Jiralite added REST semver:minor labels Aug 15, 2022

iCrawl modified the milestones: discord.js v14.3, discord.js v14.4 Aug 22, 2022

dager-mohamed closed this by deleting the head repository Aug 27, 2022

dager-mohamed reopened this Sep 4, 2022

Jiralite modified the milestones: discord.js v14.4, discord.js v14.5, discord.js v14.6 Sep 21, 2022

dager-mohamed changed the title ~~feat(Emoji): support more extensions inside url() function~~ feat(Emoji): create getURL() function to get more extension of emoji Sep 26, 2022

iCrawl modified the milestones: discord.js v14.6, discord.js v14.7 Oct 10, 2022

NotSugden suggested changes Oct 11, 2022

View reviewed changes

Jiralite removed this from the discord.js v14.7 milestone Nov 3, 2022

Jiralite mentioned this pull request Aug 20, 2023

feat(Emoji): Add imageURL() #9788

Merged

Jiralite closed this Aug 20, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(Emoji): create `getURL()` function to get more extension of emoji #8493

feat(Emoji): create `getURL()` function to get more extension of emoji #8493

dager-mohamed commented Aug 15, 2022 •

edited

Loading

vercel bot commented Aug 15, 2022 •

edited

Loading

manuelvleeuwen left a comment

jaw0r3k commented Aug 15, 2022

dager-mohamed commented Aug 15, 2022 •

edited

Loading

jaw0r3k commented Aug 15, 2022

dager-mohamed commented Aug 15, 2022

dager-mohamed commented Aug 15, 2022

codecov bot commented Aug 15, 2022 •

edited

Loading

NotSugden Oct 11, 2022

jaw0r3k Jul 30, 2023 •

edited

Loading

NotSugden Oct 11, 2022

Jiralite commented Aug 20, 2023

	public getURL(ext: ImageExtension): string;
	public getURL(ext: ImageExtension): string \| null;

feat(Emoji): create getURL() function to get more extension of emoji #8493

feat(Emoji): create getURL() function to get more extension of emoji #8493

Conversation

dager-mohamed commented Aug 15, 2022 • edited Loading

vercel bot commented Aug 15, 2022 • edited Loading

manuelvleeuwen left a comment

Choose a reason for hiding this comment

jaw0r3k commented Aug 15, 2022

dager-mohamed commented Aug 15, 2022 • edited Loading

jaw0r3k commented Aug 15, 2022

dager-mohamed commented Aug 15, 2022

dager-mohamed commented Aug 15, 2022

codecov bot commented Aug 15, 2022 • edited Loading

Codecov Report

NotSugden Oct 11, 2022

Choose a reason for hiding this comment

jaw0r3k Jul 30, 2023 • edited Loading

Choose a reason for hiding this comment

NotSugden Oct 11, 2022

Choose a reason for hiding this comment

Jiralite commented Aug 20, 2023

feat(Emoji): create `getURL()` function to get more extension of emoji #8493

feat(Emoji): create `getURL()` function to get more extension of emoji #8493

dager-mohamed commented Aug 15, 2022 •

edited

Loading

vercel bot commented Aug 15, 2022 •

edited

Loading

dager-mohamed commented Aug 15, 2022 •

edited

Loading

codecov bot commented Aug 15, 2022 •

edited

Loading

jaw0r3k Jul 30, 2023 •

edited

Loading