feat: support resume urls #8784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
github-actions
bot
requested review from
iCrawl,
kyranet,
SpaceEEC and
vladfrangu
almeidx
requested changes
Oct 25, 2022
Co-authored-by: Almeida <almeidx@pm.me>
|
Running |
Codecov Report
@@ Coverage Diff @@
## main #8784 +/- ##
==========================================
- Coverage 92.06% 85.81% -6.26%
==========================================
Files 10 91 +81
Lines 2093 9254 +7161
Branches 240 1125 +885
==========================================
+ Hits 1927 7941 +6014
- Misses 163 1271 +1108
- Partials 3 42 +39
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
didinele
approved these changes
Oct 27, 2022
didinele
requested changes
Oct 27, 2022
Syjalo
suggested changes
Oct 27, 2022
|
Discord.JS uses pascal case so why we need url to be all capital? |
We always uppercase abbreviations, e.g. |
|
Ok then, applied the changes you requested |
didinele
approved these changes
Oct 27, 2022
SpaceEEC
approved these changes
Oct 27, 2022
kyranet
approved these changes
Oct 27, 2022
Jiralite
reviewed
Oct 27, 2022
| @@ -64,6 +64,13 @@ class WebSocketShard extends EventEmitter { | |||
| */ | |||
| this.sessionId = null; | |||
|
|
|||
| /** | |||
| * The resume url for this shard | |||
There was a problem hiding this comment.
Suggested change
| * The resume url for this shard | |
| * The resume URL for this shard |
| @@ -842,10 +852,11 @@ class WebSocketShard extends EventEmitter { | |||
| // Step 4: Cache the old sequence (use to attempt a resume) | |||
| if (this.sequence !== -1) this.closeSequence = this.sequence; | |||
|
|
|||
| // Step 5: Reset the sequence and session id if requested | |||
| // Step 5: Reset the sequence, resume url and session id if requested | |||
There was a problem hiding this comment.
Suggested change
| // Step 5: Reset the sequence, resume url and session id if requested | |
| // Step 5: Reset the sequence, resume URL and session id if requested |
iCrawl
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Resume urls was not added in v14 despite on changelogs saying it is, was only added on
@discordjs/wsStatus and versioning classification: