-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(guide): Add formatters popular topic #9566
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://discord-js-guide-git-feat-gde-14-discordjs.vercel.app/guide/home/introduction |
<CH.Code> | ||
|
||
```js | ||
import { bold, italic, strikethrough, underscore, spoiler, quote, blockQuote } from 'discord.js'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this show imports from @discordjs/formatters
then, since its a guide for it? 👀 Or should it instead be mentioned as an alternative?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be a tip; generally the right choice, though
Edit: actually, should probably rephrase the introduction sentence a bit.
Codecov Report
@@ Coverage Diff @@
## main #9566 +/- ##
==========================================
+ Coverage 58.20% 58.26% +0.06%
==========================================
Files 227 227
Lines 14902 14881 -21
Branches 1133 1133
==========================================
- Hits 8673 8670 -3
+ Misses 6189 6171 -18
Partials 40 40
Flags with carried forward coverage won't be shown. Click here to find out more. see 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Please describe the changes this PR makes and why it should be merged:
Adds the formatters popular topic.