Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(guide): Add formatters popular topic #9566

Merged
merged 4 commits into from
May 22, 2023
Merged

feat(guide): Add formatters popular topic #9566

merged 4 commits into from
May 22, 2023

Conversation

Jiralite
Copy link
Member

Please describe the changes this PR makes and why it should be merged:
Adds the formatters popular topic.

@Jiralite Jiralite added this to the Guide Rebuild milestone May 12, 2023
@Jiralite Jiralite requested a review from a team as a code owner May 12, 2023 20:28
@vercel
Copy link

vercel bot commented May 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-js-guide ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 18, 2023 9:13am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) May 18, 2023 9:13am

@github-actions
Copy link

github-actions bot commented May 12, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 87
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 94
🟠 PWA 70

Lighthouse ran on https://discord-js-guide-git-feat-gde-14-discordjs.vercel.app/guide/home/introduction

<CH.Code>

```js
import { bold, italic, strikethrough, underscore, spoiler, quote, blockQuote } from 'discord.js';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this show imports from @discordjs/formatters then, since its a guide for it? 👀 Or should it instead be mentioned as an alternative?

Copy link
Member

@almostSouji almostSouji May 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be a tip; generally the right choice, though
Edit: actually, should probably rephrase the introduction sentence a bit.

@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Merging #9566 (765f97d) into main (cffa5d1) will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #9566      +/-   ##
==========================================
+ Coverage   58.20%   58.26%   +0.06%     
==========================================
  Files         227      227              
  Lines       14902    14881      -21     
  Branches     1133     1133              
==========================================
- Hits         8673     8670       -3     
+ Misses       6189     6171      -18     
  Partials       40       40              
Flag Coverage Δ
guide 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@iCrawl iCrawl merged commit 4784349 into main May 22, 2023
@iCrawl iCrawl deleted the feat/GDE-14 branch May 22, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants