-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): add stage instances #9578
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
e9461c9
to
10bebcc
Compare
Co-authored-by: Aura Román <kyradiscord@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ids are snowflakes. Please check the types.
There are 177 results for "The options for..." and 59 for "The options to use...". We're inconsistent here, so try to go with the majority and hopefully a future pull request can standardise the documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, adding to my previous review, all the places where a stage instance id has been documented are wrong. It should be the channel id. Using a stage instance id will throw an Unknown Channel
error.
Co-authored-by: David Malchin <malchin459@gmail.com> Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
Co-authored-by: David Malchin <malchin459@gmail.com> Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## main #9578 +/- ##
==========================================
+ Coverage 58.17% 58.20% +0.02%
==========================================
Files 227 227
Lines 14891 14902 +11
Branches 1130 1133 +3
==========================================
+ Hits 8663 8673 +10
- Misses 6188 6189 +1
Partials 40 40 see 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://discord-js-git-fork-jaw0r3k-core-stageinstances-discordjs.vercel.app/ |
Please describe the changes this PR makes and why it should be merged:
🤖 Generated by Copilot at c2697cd
This pull request adds a new
StageInstancesAPI
class to thecore
package, which allows interacting with the stage instances resource of the Discord API. The class has methods for creating, getting, editing, and deleting stage instances, using the types and routes from thediscord-api-types
package. The class is exported from theapi/index.ts
file and added to theAPI
class.Status and versioning classification: