Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(User): return just the username in tag for new usernames #9585

Closed
wants to merge 1 commit into from
Closed

feat(User): return just the username in tag for new usernames #9585

wants to merge 1 commit into from

Conversation

alula
Copy link

@alula alula commented May 18, 2023

Please describe the changes this PR makes and why it should be merged:
Makes User.tag return just the username instead of username#0 for new (Pomelo) usernames.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

@alula alula requested a review from a team as a code owner May 18, 2023 21:25
@vercel
Copy link

vercel bot commented May 18, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) May 18, 2023 9:25pm
discord-js-guide ⬜️ Ignored (Inspect) May 18, 2023 9:25pm

@Jiralite
Copy link
Member

Duplicate of #9512.

@Jiralite Jiralite closed this May 18, 2023
@alula alula deleted the patch-2 branch May 19, 2023 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu Awaiting requested review from vladfrangu vladfrangu is a code owner automatically assigned from discordjs/core

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner automatically assigned from discordjs/core

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

Assignees
No one assigned
Labels
duplicate packages:discord.js
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alula @Jiralite