chore(guide): update username system references #9652
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
Should I also make changes to the jsdocs in this PR or should that be separate? |
Jiralite
changed the title
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://discord-js-guide-git-fork-uhkevinmc-guide-upda-8aa6bd-discordjs.vercel.app/guide/home/introduction |
uhKevinMC
requested review from
monbrey,
vladfrangu,
iCrawl,
almostSouji,
Jiralite and
suneettipirneni
|
we are not yet even sure if we want to/need to deprecate #tag |
| array.find((user) => user.bot === true); | ||
| collection.find((user) => user.bot === true); |
There was a problem hiding this comment.
| array.find((user) => user.bot === true); | |
| collection.find((user) => user.bot === true); | |
| array.find((user) => user.bot); | |
| collection.find((user) => user.bot); |
There was a problem hiding this comment.
Idk if looking for bots is a good example
user.username.includes("cat") looks cooler
There was a problem hiding this comment.
This code chunk was originally to filter for users with the discriminator of #1000, so I think @jaw0r3k's suggestion would be better suited for this use case..
Still waiting to see if this PR will be considered necessary since there is a discussion about .tag being "un-deprecated" or not.
There was a problem hiding this comment.
Disciminators wont be used by regular users
So this example should be changed
But leave tag code as bots still uses it
uhKevinMC
force-pushed
the
guide-update-username-references
branch
from
ef5c0d0 to
99bb3b5
Compare
|
|
Please describe the changes this PR makes and why it should be merged:
This PR changes references of
.tagand.discriminatorin the guide to alternatives in anticipation of those properties being deprecated.Status and versioning classification: