Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Update vite and other related dependencies #9772

Merged
merged 2 commits into from
Aug 13, 2023
Merged

Conversation

Jiralite
Copy link
Member

@Jiralite Jiralite commented Aug 13, 2023

Please describe the changes this PR makes and why it should be merged:
@vitest/coverage-c8 was deprecated in favour of @vitest/coverage-v8.

This also resolves the CI errors (caused by a deprecation warning error) in packages/ui/vite.config.ts. "outputMode": "full" was specified in turbo.json to see better debug logs which has since been changed to "errors-only".

Status and versioning classification:

  • This PR only includes non-code changes, like changes to documentation, README, etc.

@vercel
Copy link

vercel bot commented Aug 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Aug 13, 2023 7:29pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Aug 13, 2023 7:29pm

@github-actions
Copy link

github-actions bot commented Aug 13, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 62
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 94
🟠 PWA 70

Lighthouse ran on https://discord-js-guide-git-build-update-vite-discordjs.vercel.app/guide/home/introduction

@codecov
Copy link

codecov bot commented Aug 13, 2023

Codecov Report

Merging #9772 (454a7cb) into main (447652e) will increase coverage by 2.14%.
Report is 24 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #9772      +/-   ##
==========================================
+ Coverage   57.43%   59.58%   +2.14%     
==========================================
  Files         232      234       +2     
  Lines       15050    15862     +812     
  Branches     1126     1195      +69     
==========================================
+ Hits         8644     9451     +807     
  Misses       6366     6366              
- Partials       40       45       +5     
Flag Coverage Δ
brokers 63.16% <ø> (ø)
builders 98.69% <ø> (ø)
collection 99.87% <ø> (ø)
formatters 99.38% <ø> (?)
guide 0.00% <ø> (ø)
proxy 76.31% <ø> (ø)
rest 92.69% <ø> (ø)
util 70.55% <ø> (ø)
utilities 100.00% <ø> (ø)
voice 63.53% <ø> (ø)
website 0.00% <ø> (ø)
ws 52.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@iCrawl iCrawl merged commit a1605b3 into main Aug 13, 2023
21 checks passed
@iCrawl iCrawl deleted the build/update-vite branch August 13, 2023 19:36
almeidx pushed a commit to almeidx/discord.js that referenced this pull request Sep 24, 2023
* build: update vite and other related dependencies

* chore: use `"errors-only"`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants