Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use super on webhook delete #9906

Closed
wants to merge 1 commit into from
Closed

fix: use super on webhook delete #9906

wants to merge 1 commit into from

Conversation

jaw0r3k
Copy link
Contributor

@jaw0r3k jaw0r3k commented Oct 22, 2023

Please describe the changes this PR makes and why it should be merged:
Supersedes:

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@jaw0r3k jaw0r3k requested a review from a team as a code owner October 22, 2023 13:53
@vercel
Copy link

vercel bot commented Oct 22, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Oct 22, 2023 2:21pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Oct 22, 2023 2:21pm

@github-actions
Copy link

github-actions bot commented Oct 22, 2023 •
edited
Loading

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 49
🟢 Accessibility 96
🟢 Best practices 100
🟠 SEO 67
🔴 PWA 33

Lighthouse ran on https://discord-js-guide-git-fork-jaw0r3k-user-super-o-5c348b-discordjs.vercel.app/

@Jiralite
Copy link
Member

Jiralite commented Oct 22, 2023 •
edited
Loading

There is no super. This will not work.

The class can be instantiated by fetching webhooks. super.client will be undefined.

@jaw0r3k @kyranet
fix: use super on webhook delete
f6fc234 
Co-authored-by: Kyra <kyradiscord@gmail.com>
@jaw0r3k jaw0r3k force-pushed the user-super-on-webhook-delete branch from b25d43e to f6fc234 Compare October 22, 2023 14:20
@Jiralite
Copy link
Member

This is not going to work either because it will be overridden by Webhook's symbol. Even if you remove it, it won't work as super.delete is not a function.

@jaw0r3k
Copy link
Contributor Author

jaw0r3k commented Oct 22, 2023

oh yeah it just implements webhook...

@jaw0r3k jaw0r3k closed this Oct 22, 2023
@jaw0r3k jaw0r3k deleted the user-super-on-webhook-delete branch November 5, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu Awaiting requested review from vladfrangu vladfrangu is a code owner automatically assigned from discordjs/core

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner automatically assigned from discordjs/core

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

Assignees
No one assigned
Labels
invalid packages:discord.js
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaw0r3k @Jiralite