Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: premium application subscriptions #9907

Merged
merged 5 commits into from
Dec 24, 2023

Conversation

almeidx
Copy link
Member

@almeidx almeidx commented Oct 22, 2023

@vercel
Copy link

vercel bot commented Oct 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 24, 2023 3:48pm
discord-js-guide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 24, 2023 3:48pm

pnpm-lock.yaml Outdated Show resolved Hide resolved
@almeidx almeidx force-pushed the discord.js/premium-app-subscriptions branch from 0d7ddb7 to 61e3f22 Compare October 23, 2023 13:12
@github-actions
Copy link

github-actions bot commented Oct 23, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 81
🟢 Accessibility 96
🟢 Best practices 100
🟠 SEO 67
🔴 PWA 33

Lighthouse ran on https://discord-js-git-discordjs-premium-app-subscriptions-discordjs.vercel.app/

@almeidx almeidx marked this pull request as ready for review October 23, 2023 13:17
@almeidx almeidx requested a review from a team as a code owner October 23, 2023 13:17
@almeidx almeidx force-pushed the discord.js/premium-app-subscriptions branch from 73f126e to 092628f Compare October 23, 2023 19:06
@Jiralite
Copy link
Member

Will partials be added here in case? Are they even necessary?

packages/discord.js/src/structures/Entitlement.js Outdated Show resolved Hide resolved
packages/discord.js/src/structures/Entitlement.js Outdated Show resolved Hide resolved
@almeidx
Copy link
Member Author

almeidx commented Oct 25, 2023

@Jiralite I don't believe so. Discord sends the full entitlement object everywhere

@almeidx almeidx marked this pull request as draft October 27, 2023 17:45
@almeidx almeidx force-pushed the discord.js/premium-app-subscriptions branch from 4808658 to f34a343 Compare November 21, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add support for entitlement (App Subscriptions)
8 participants