-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: premium application subscriptions #9907
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jaw0r3k
reviewed
Oct 22, 2023
packages/discord.js/src/structures/interfaces/InteractionResponses.js
Outdated
Show resolved
Hide resolved
jaw0r3k
reviewed
Oct 22, 2023
vladfrangu
requested changes
Oct 22, 2023
packages/discord.js/src/structures/interfaces/InteractionResponses.js
Outdated
Show resolved
Hide resolved
Jiralite
reviewed
Oct 22, 2023
packages/discord.js/src/structures/interfaces/InteractionResponses.js
Outdated
Show resolved
Hide resolved
almeidx
force-pushed
the
discord.js/premium-app-subscriptions
branch
from
October 23, 2023 13:12
0d7ddb7
to
61e3f22
Compare
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://discord-js-git-discordjs-premium-app-subscriptions-discordjs.vercel.app/ |
almeidx
force-pushed
the
discord.js/premium-app-subscriptions
branch
from
October 23, 2023 19:06
73f126e
to
092628f
Compare
Will partials be added here in case? Are they even necessary? |
vladfrangu
previously requested changes
Oct 24, 2023
Dymidless
approved these changes
Oct 25, 2023
@Jiralite I don't believe so. Discord sends the full entitlement object everywhere |
Jiralite
reviewed
Oct 28, 2023
almeidx
force-pushed
the
discord.js/premium-app-subscriptions
branch
from
November 21, 2023 19:13
4808658
to
f34a343
Compare
This was referenced Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Adds SKU and Entitlement support to core and discord.js
Resolves #9856
Upstream:
Depends on:
Status and versioning classification: