Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: present x-ratelimit-scope for 429s hit #9973

Merged
merged 2 commits into from
Nov 16, 2023
Merged

feat: present x-ratelimit-scope for 429s hit #9973

merged 2 commits into from
Nov 16, 2023

Conversation

vladfrangu
Copy link
Member

Please describe the changes this PR makes and why it should be merged:

Just useful for debugging purposes, it's not something we need to handle as our current ratelimit impl already takes care of it

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@vladfrangu vladfrangu requested a review from a team as a code owner November 16, 2023 10:03
@vercel Vercel
Copy link

vercel bot commented Nov 16, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Nov 16, 2023 10:10am
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Nov 16, 2023 10:10am

@codecov Codecov
Copy link

codecov bot commented Nov 16, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0aa7dc1) 59.11% compared to head (8aacab8) 59.16%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9973      +/-   ##
==========================================
+ Coverage   59.11%   59.16%   +0.04%     
==========================================
  Files         240      240              
  Lines       16908    16926      +18     
  Branches     1240     1240              
==========================================
+ Hits         9996    10014      +18     
  Misses       6867     6867              
  Partials       45       45
Flag Coverage Δ
next ∅ <ø> (∅)
proxy 75.00% <ø> (ø)
rest 92.87% <100.00%> (+0.05%) ⬆️
ws 52.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jiralite Jiralite added this to the rest 2.2.0 milestone Nov 16, 2023
ckohen
ckohen approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@ckohen ckohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I like the scope being at the end of the debug string, but the rest of the order is kind random too, so that's out of scope (haha) for this PR

@kodiakhq kodiakhq bot merged commit 6df233d into main Nov 16, 2023
23 checks passed
@kodiakhq kodiakhq bot deleted the feat/add-ratelimit-scope-to-ratelimit-data branch November 16, 2023 10:49
Vylpes pushed a commit to Vylpes/card-drop that referenced this pull request Nov 27, 2023
@Vylpes
Update dependency @discordjs/rest to v2.2.0 (#101)
e96f173 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@discordjs/rest](https://discord.js.org) ([source](https://github.com/discordjs/discord.js)) | dependencies | minor | [`2.0.1` -> `2.2.0`](https://renovatebot.com/diffs/npm/@discordjs%2frest/2.0.1/2.2.0) |

---

### Release Notes

<details>
<summary>discordjs/discord.js (@&#8203;discordjs/rest)</summary>

### [`v2.2.0`](https://github.com/discordjs/discord.js/blob/HEAD/packages/rest/CHANGELOG.md#discordjsrest220---2023-11-17)

[Compare Source](https://github.com/discordjs/discord.js/compare/@discordjs/rest@2.1.0...@discordjs/rest@2.2.0)

#### Bug Fixes

-   Minify mainlib docs json ([#&#8203;9963](discordjs/discord.js#9963)) ([4b88306](discordjs/discord.js@4b88306))

#### Features

-   Present x-ratelimit-scope for 429s hit ([#&#8203;9973](discordjs/discord.js#9973)) ([6df233d](discordjs/discord.js@6df233d))

#### Typings

-   Use wrapper utilities ([#&#8203;9945](discordjs/discord.js#9945)) ([4bc1dae](discordjs/discord.js@4bc1dae))

### [`v2.1.0`](https://github.com/discordjs/discord.js/blob/HEAD/packages/rest/CHANGELOG.md#discordjsrest210---2023-11-12)

[Compare Source](https://github.com/discordjs/discord.js/compare/@discordjs/rest@2.0.1...@discordjs/rest@2.1.0)

#### Bug Fixes

-   **REST:** Strip webhook tokens ([#&#8203;9723](discordjs/discord.js#9723)) ([cf49f40](discordjs/discord.js@cf49f40))

#### Documentation

-   Fix "its" typo ([#&#8203;9825](discordjs/discord.js#9825)) ([c50809e](discordjs/discord.js@c50809e))
-   **create-discord-bot:** Support bun in create-discord-bot ([#&#8203;9798](discordjs/discord.js#9798)) ([7157748](discordjs/discord.js@7157748))

#### Features

-   Expose Retry-After and sublimit timeouts in RatelimitData ([#&#8203;9864](discordjs/discord.js#9864)) ([81e7866](discordjs/discord.js@81e7866))
-   **CDN:** Support emoji size ([#&#8203;9787](discordjs/discord.js#9787)) ([778df45](discordjs/discord.js@778df45))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4wLjAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4wLjAiLCJ0YXJnZXRCcmFuY2giOiJkZXZlbG9wIn0=-->

Reviewed-on: https://gitea.vylpes.xyz/External/card-drop/pulls/101
Reviewed-by: Vylpes <ethan@vylpes.com>
Co-authored-by: Renovate Bot <renovate@vylpes.com>
Co-committed-by: Renovate Bot <renovate@vylpes.com>
Vylpes pushed a commit to Vylpes/vylbot-app that referenced this pull request Dec 18, 2023
@Vylpes
Update dependency @discordjs/rest to v2.2.0 (#375)
4eabb2f 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@discordjs/rest](https://discord.js.org) ([source](https://github.com/discordjs/discord.js)) | dependencies | minor | [`2.0.1` -> `2.2.0`](https://renovatebot.com/diffs/npm/@discordjs%2frest/2.0.1/2.2.0) |

---

### Release Notes

<details>
<summary>discordjs/discord.js (@&#8203;discordjs/rest)</summary>

### [`v2.2.0`](https://github.com/discordjs/discord.js/blob/HEAD/packages/rest/CHANGELOG.md#discordjsrest220---2023-11-17)

[Compare Source](https://github.com/discordjs/discord.js/compare/@discordjs/rest@2.1.0...@discordjs/rest@2.2.0)

#### Bug Fixes

-   Minify mainlib docs json ([#&#8203;9963](discordjs/discord.js#9963)) ([4b88306](discordjs/discord.js@4b88306))

#### Features

-   Present x-ratelimit-scope for 429s hit ([#&#8203;9973](discordjs/discord.js#9973)) ([6df233d](discordjs/discord.js@6df233d))

#### Typings

-   Use wrapper utilities ([#&#8203;9945](discordjs/discord.js#9945)) ([4bc1dae](discordjs/discord.js@4bc1dae))

### [`v2.1.0`](https://github.com/discordjs/discord.js/blob/HEAD/packages/rest/CHANGELOG.md#discordjsrest210---2023-11-12)

[Compare Source](https://github.com/discordjs/discord.js/compare/@discordjs/rest@2.0.1...@discordjs/rest@2.1.0)

#### Bug Fixes

-   **REST:** Strip webhook tokens ([#&#8203;9723](discordjs/discord.js#9723)) ([cf49f40](discordjs/discord.js@cf49f40))

#### Documentation

-   Fix "its" typo ([#&#8203;9825](discordjs/discord.js#9825)) ([c50809e](discordjs/discord.js@c50809e))
-   **create-discord-bot:** Support bun in create-discord-bot ([#&#8203;9798](discordjs/discord.js#9798)) ([7157748](discordjs/discord.js@7157748))

#### Features

-   Expose Retry-After and sublimit timeouts in RatelimitData ([#&#8203;9864](discordjs/discord.js#9864)) ([81e7866](discordjs/discord.js@81e7866))
-   **CDN:** Support emoji size ([#&#8203;9787](discordjs/discord.js#9787)) ([778df45](discordjs/discord.js@778df45))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4wLjAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4wLjAiLCJ0YXJnZXRCcmFuY2giOiJkZXZlbG9wIn0=-->

Reviewed-on: https://gitea.vylpes.xyz/RabbitLabs/vylbot-app/pulls/375
Reviewed-by: Vylpes <ethan@vylpes.com>
Co-authored-by: Renovate Bot <renovate@vylpes.com>
Co-committed-by: Renovate Bot <renovate@vylpes.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jiralite Jiralite Jiralite approved these changes

@kyranet kyranet kyranet approved these changes

@ckohen ckohen ckohen approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/rest

@didinele didinele Awaiting requested review from didinele didinele is a code owner automatically assigned from discordjs/rest

Assignees
No one assigned
Labels
packages:rest semver:minor
Projects
discord.js
Archived in project
Milestone
rest 2.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@vladfrangu @ckohen @kyranet @Jiralite