Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Bump versions #9986

Merged
merged 2 commits into from
Dec 30, 2023
Merged

build: Bump versions #9986

merged 2 commits into from
Dec 30, 2023

Conversation

Jiralite
Copy link
Member

@Jiralite Jiralite commented Nov 18, 2023

Bumps dependencies.

Copy link

vercel bot commented Nov 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 30, 2023 6:00pm
discord-js-guide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 30, 2023 6:00pm

@jaw0r3k
Copy link
Contributor

jaw0r3k commented Nov 18, 2023

Doesnt seem working for me...

Updated versions:
image

image

@vladfrangu
Copy link
Member

@jaw0r3k please npm ls @discordjs/rest 🙏

@mallusrgreatv2
Copy link

mallusrgreatv2 commented Nov 18, 2023

@jaw0r3k please npm ls @discordjs/rest 🙏

I also have the same issue:

│ ├── @discordjs/rest@2.2.0
│ └─┬ @discordjs/ws@1.0.2
│   └── @discordjs/rest@2.2.0 deduped
└─┬ discord.js@14.14.1
  └── @discordjs/rest@2.2.0 deduped

@vladfrangu
Copy link
Member

PR is blocked till we get a resolution for microsoft/TypeScript#56455 🤞

@ckohen
Copy link
Member

ckohen commented Nov 19, 2023

For those that find this PR before that is resolved, a solution is importing directly from @discordjs/rest since it has exports for both module types that TS resolves properly.

@darionbuilds
Copy link

PR is blocked till we get a resolution for microsoft/TypeScript#56455 🤞

Just as an FYI, this was marked as working as intended on the TS repo.

@ckohen
Copy link
Member

ckohen commented Nov 26, 2023

Which unfortunately means my previous suggestion is the best way to overcome this. I think we plan on making it work by faking djs having esm support in TS land, which is incredibly dumb, and balloons the package size for literally no reason, but alas.

@Jiralite Jiralite changed the title fix: Bump versions to prevent /rest type error build: Bump versions Nov 30, 2023
@Jiralite
Copy link
Member Author

#10009 was raised to fix #9985, so this will just bump dependencies.

@Jiralite Jiralite removed the blocked label Nov 30, 2023
Copy link

codecov bot commented Dec 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ce84d3e) 58.36% compared to head (417f314) 58.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9986      +/-   ##
==========================================
- Coverage   58.36%   58.34%   -0.03%     
==========================================
  Files         242      242              
  Lines       17184    17190       +6     
  Branches     1243     1243              
==========================================
  Hits        10029    10029              
- Misses       7110     7116       +6     
  Partials       45       45              
Flag Coverage Δ
brokers 63.49% <ø> (ø)
builders 95.53% <ø> (ø)
collection 99.32% <ø> (ø)
formatters 99.27% <ø> (ø)
guide 0.00% <ø> (ø)
next ∅ <ø> (∅)
proxy 75.00% <ø> (ø)
rest 92.87% <ø> (ø)
util 70.70% <ø> (ø)
utilities 100.00% <ø> (ø)
voice 63.64% <ø> (ø)
website 0.00% <ø> (ø)
ws 52.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kodiakhq kodiakhq bot merged commit 136c66c into main Dec 30, 2023
23 checks passed
@kodiakhq kodiakhq bot deleted the fix/bump-versions branch December 30, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

8 participants