Build discourse/base and discourse/discourse_test image for bookworm
#823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgxworld
force-pushed
the
upgrade_to_debian_bookworm
branch
11 times, most recently
from
b0de515 to
a0bf234
Compare
We need to upgrade to bookworm because bullseye is EOL.
tgxworld
force-pushed
the
upgrade_to_debian_bookworm
branch
from
a0bf234 to
71c34b4
Compare
tgxworld
commented
Aug 8, 2024
| else | ||
| # Use backports instead of compiling it | ||
| apt -y -q install -t bullseye-backports libheif1 libaom-dev libheif-dev |
There was a problem hiding this comment.
libheif1 libheif-dev are not part of bullseye-backport
tgxworld
commented
Aug 8, 2024
Comment on lines
+34
to
+37
| RUN install -d /usr/share/postgresql-common/pgdg &&\ | ||
| curl -o /usr/share/postgresql-common/pgdg/apt.postgresql.org.asc --fail https://www.postgresql.org/media/keys/ACCC4CF8.asc &&\ | ||
| echo "deb [signed-by=/usr/share/postgresql-common/pgdg/apt.postgresql.org.asc] https://apt.postgresql.org/pub/repos/apt ${DEBIAN_RELEASE}-pgdg main" > /etc/apt/sources.list.d/pgdg.list | ||
|
|
There was a problem hiding this comment.
Updated based on https://www.postgresql.org/download/linux/debian/
tgxworld
commented
Aug 8, 2024
| @@ -145,6 +190,47 @@ jobs: | |||
| docker push discourse/discourse_test:slim | |||
| docker push discourse/discourse_test:slim-browsers | |||
| docker push discourse/discourse_test:release | |||
| test_bookworm: | |||
There was a problem hiding this comment.
This will only work on the main branch since the image has not been pushed to Dockerhub
There was a problem hiding this comment.
This is also a simplified version of the test job.
tgxworld
commented
Aug 8, 2024
| @@ -104,6 +104,51 @@ jobs: | |||
| run: | | |||
| docker tag discourse/base:release${{ steps.arch-helper.outputs.arch_postfix_dash }} discourse/base:aarch64 | |||
| docker push discourse/base:aarch64 | |||
| base_bookworm: | |||
There was a problem hiding this comment.
This is a simplified version of the base job.
CvX
approved these changes
Aug 8, 2024
| runs-on: ubuntu-20.04${{ ((github.event_name != 'schedule') && '-8core') || '' }} | ||
| timeout-minutes: ${{ github.event_name != 'schedule' && 30 }} | ||
| steps: | ||
| - uses: actions/checkout@v3 |
There was a problem hiding this comment.
btw, the latest version of checkout is v4. we could add a dependabot config to this repo to bump this stuff for us
|
Thank you for reviewing @CvX 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to upgrade to bookworm because bullseye is EOL. This commit when merged into branch will push the following images to Docker hub:
discourse/base:slim-bookwormdiscourse/base:release-bookwormdiscourse/discourse_test:slim-bookwormdiscourse/discourse_test:slim-browsers-bookwormdiscourse/discourse_test:release-bookworm