Use Nginx config with outlets #913
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbianca
force-pushed
the
dev-nginx-conf
branch
from
a8e3a89 to
8250508
Compare
nbianca
force-pushed
the
dev-nginx-conf
branch
from
8250508 to
135aab5
Compare
nbianca
changed the title
nbianca
force-pushed
the
dev-nginx-conf
branch
4 times, most recently
from
ca741a9 to
12299cc
Compare
nbianca
changed the title
tgxworld
reviewed
Jan 23, 2025
Comment on lines
+10
to
+17
| - file: | ||
| path: "/etc/nginx/conf.d/outlets/server/offline-page.conf" | ||
| contents: | | ||
| error_page 502 /error_page.html; | ||
| location /error_page.html { | ||
| root /var/www/discourse-offline-page/html; | ||
| internal; | ||
| } |
There was a problem hiding this comment.
I think we need to consider deployments that have Discourse pinned to the stable branch. The outlets will not be present until stable is bumped to include the new nginx configuration.
This config has several 'include' statements that serve as extension outlets. Most of the "find & replace" instructions from templates files have been replaced to use outlets. This commit also deprecates IPv6 template in favour of an automatic implementation that relies on container's connectivity.
nbianca
force-pushed
the
dev-nginx-conf
branch
from
12299cc to
e216fa7
Compare
tgxworld
reviewed
Jan 24, 2025
| filename: "/etc/nginx/conf.d/discourse.conf" | ||
| from: /listen 80;/ | ||
| filename: "/etc/nginx/conf.d/outlets/server/http.conf" | ||
| from: /listen 80;(\nlisten \[::\]:80;)?/ |
There was a problem hiding this comment.
Do we still need to use a replace here? We could just overwrite the file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This config has several 'include' statements that serve as extension
outlets. Most of the "find & replace" instructions from templates
files have been replaced to use outlets.
This commit also deprecates IPv6 template in favour of an automatic
implementation that relies on container's connectivity.