Skip to content

Commit

Permalink
Remove try/catch in Widget#queryBool() (fixes #69)
Browse files Browse the repository at this point in the history
  • Loading branch information
lahmatiy committed Nov 3, 2020
1 parent 3d2de4c commit 845d9d4
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
- Fixed dark mode styles of action buttons in `struct` view for touch devices
- Fixed context for nav to include route attributes (#70)
- Added `nav.remove(name)` method to remove nav items (#72)
- Removed try/catch in `Widget#queryBool()`, so now `when` and `whenData` throws instead of silently fail (#69)

## 1.0.0-beta.47 (02-11-2020)

Expand Down
6 changes: 1 addition & 5 deletions src/widget/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -348,11 +348,7 @@ export default class Widget extends Emitter {
}

queryBool(...args) {
try {
return jora.buildin.bool(this.query(...args));
} catch (e) {
return false;
}
return jora.buildin.bool(this.query(...args));
}

queryToConfig(view, query) {
Expand Down

0 comments on commit 845d9d4

Please sign in to comment.