Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make Gateway.Open wait until ready event is received #321

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

make Gateway.Open wait until ready event is received #321

wants to merge 4 commits into from

Conversation

topi314
Copy link
Member

@topi314 topi314 commented Oct 4, 2023 •
edited
Loading

Gateway.Open should wait until we received the ready event to verify the token & other stuff is valid

@topi314 topi314 marked this pull request as ready for review October 4, 2023 08:45
@topi314 topi314 self-assigned this Oct 4, 2023
@topi314 topi314 force-pushed the patch/gateway-open-wait-ready-event branch from 2d031d2 to 80ccb75 Compare October 4, 2023 23:18
topi314
topi314 commented Oct 10, 2023
View reviewed changes
Copy link
Member Author

@topi314 topi314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems to work now, we are conducting final testing

@joshuasing
Copy link

Hi, is this likely to be merged soon? I think it would be very useful to have. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@topi314 topi314

Labels
s:completed t:gateway type:enhancement
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@topi314 @joshuasing