Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump smithy to 1.49.0 #1485

Merged
merged 27 commits into from
May 15, 2024
Merged

Bump smithy to 1.49.0 #1485

merged 27 commits into from
May 15, 2024

Conversation

kubukoz
Copy link
Member

@kubukoz kubukoz commented Apr 11, 2024

[@Baccata's comment]

In addition to bumping smithy, adds an option for lenient tagged union decoding, used in the context of AWS. This fixes a few compliance tests that were previously broken (#1424)

PR Checklist (not all items are relevant to all PRs)

  • Added unit-tests (for runtime code)
  • Updated changelog

@Baccata Baccata marked this pull request as ready for review April 12, 2024 13:32
@kubukoz kubukoz changed the title Bump smithy to 1.47.0 Bump smithy to 1.4780 May 9, 2024
@kubukoz kubukoz changed the title Bump smithy to 1.4780 Bump smithy to 1.48.0 May 9, 2024
@kubukoz kubukoz changed the title Bump smithy to 1.48.0 Bump smithy to 1.49.0 May 9, 2024
@kubukoz kubukoz marked this pull request as draft May 9, 2024 23:35
@kubukoz
Copy link
Member Author

kubukoz commented May 9, 2024

[error] [aws-http4s] - aws.protocoltests.ec2#QueryLists(client|Request): Ec2EmptyQueryLists 89ms
[error] [aws-http4s]    the result value: "Action=QueryLists&Version=2020-01-08&ListArg=" was not equal to the expected TestCase value "Action=QueryLists&Version=2020-01-08". (modules/tests/src/smithy4s/tests/ProtocolComplianceSuite.scala:183)
[error] [aws-http4s] 
[error] [aws-http4s]     [INFO] 23:25:07 [ProtocolComplianceSuite.scala:173] Does not serialize empty query lists.
[error] [aws-http4s] 

I think I can give this a shot, but not today.

@kubukoz kubukoz marked this pull request as ready for review May 13, 2024 15:18
CHANGELOG.md Outdated
# 0.18.19 - binary-breaking changes in `core`

**WARNING**: This release includes binary-breaking changes in the `core` module. This is indirectly caused by an upstream change in [smithy-lang/smithy](https://github.com/smithy-lang/smithy/),
and it'll most likely cause runtime issues in all applications that use a mix of versions in the ranges `0.18.0 ≤ 0.18.17` and `0.18.18+`.
Copy link
Contributor

@Baccata Baccata May 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ONLY way we can justify rolling the bump in 0.18 is by showing some confidence that it's VERY unlikely to cause runtime issues, unless people have written some very esoteric interpreters.

That's what your experiments have shown (in our DMs), with the only way you've made it blow has been with this

SomeType.hints.get(Trait).map(_.breakingChanges.map(_.map(_.severity))))

So you need to change the wording to something like:

 

In the vast majority of applications using Smithy4s, it will not cause runtime issues. However, in the unlikely event that you have custom interpreters that query the .breakingChanges field of a Trait hint, you'll have to ensure that all the libraries pulled by your application are compiled against smithy4s 0.18.19.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do some more tests to increase my confidence ;)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated the entry, does it look good?

@Baccata Baccata merged commit 4871c55 into series/0.18 May 15, 2024
11 checks passed
@Baccata Baccata deleted the bump-smithy-1470 branch May 15, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants