-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump smithy to 1.49.0 #1485
Bump smithy to 1.49.0 #1485
Conversation
I think I can give this a shot, |
CHANGELOG.md
Outdated
# 0.18.19 - binary-breaking changes in `core` | ||
|
||
**WARNING**: This release includes binary-breaking changes in the `core` module. This is indirectly caused by an upstream change in [smithy-lang/smithy](https://github.com/smithy-lang/smithy/), | ||
and it'll most likely cause runtime issues in all applications that use a mix of versions in the ranges `0.18.0 ≤ 0.18.17` and `0.18.18+`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ONLY way we can justify rolling the bump in 0.18 is by showing some confidence that it's VERY unlikely to cause runtime issues, unless people have written some very esoteric interpreters.
That's what your experiments have shown (in our DMs), with the only way you've made it blow has been with this
SomeType.hints.get(Trait).map(_.breakingChanges.map(_.map(_.severity))))
So you need to change the wording to something like:
In the vast majority of applications using Smithy4s, it will not cause runtime issues. However, in the unlikely event that you have custom interpreters that query the
.breakingChanges
field of aTrait
hint, you'll have to ensure that all the libraries pulled by your application are compiled against smithy4s 0.18.19.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll do some more tests to increase my confidence ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated the entry, does it look good?
[@Baccata's comment]
In addition to bumping smithy, adds an option for lenient tagged union decoding, used in the context of AWS. This fixes a few compliance tests that were previously broken (#1424)
PR Checklist (not all items are relevant to all PRs)