-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use default values for optional httpPayload if there is no body #1511
Merged
Baccata
merged 9 commits into
disneystreaming:series/0.18
from
ghostbuster91:default-payload
Jun 19, 2024
Merged
fix: use default values for optional httpPayload if there is no body #1511
Baccata
merged 9 commits into
disneystreaming:series/0.18
from
ghostbuster91:default-payload
Jun 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghostbuster91
changed the title
Default payload
fix: use default values for optional httpPaylaod if there is no body
May 6, 2024
This currently fails with the linked version of alloy due to:
|
ghostbuster91
commented
May 6, 2024
kubukoz
reviewed
May 8, 2024
kubukoz
changed the title
fix: use default values for optional httpPaylaod if there is no body
fix: use default values for optional httpPayload if there is no body
May 9, 2024
Have you checked this with the latest changes on the alloy side (content type related)? |
Yes, twice. |
ghostbuster91
force-pushed
the
default-payload
branch
from
June 4, 2024 17:18
e515016
to
d704f9e
Compare
Scripted test failing due to a mismatch of the Alloy version btw |
kubukoz
approved these changes
Jun 14, 2024
Baccata
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR in alloy: disneystreaming/alloy#163
This closes #1502
TODO:
PR Checklist (not all items are relevant to all PRs)