Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make examples in design section compile #1531

Merged
merged 1 commit into from
May 18, 2024

Conversation

lenguyenthanh
Copy link
Contributor

PR Checklist (not all items are relevant to all PRs)

  • Added unit-tests (for runtime code)
  • Added bootstrapped code + smoke tests (when the rendering logic is modified)
  • Added build-plugins integration tests (when reflection loading is required at codegen-time)
  • Added alloy compliance tests (when simpleRestJson protocol behaviour is expanded/updated)
  • Updated dynamic module to match generated-code behaviour
  • Added documentation
  • Updated changelog

@kubukoz
Copy link
Member

kubukoz commented May 18, 2024

Thanks! It'd be cool to have these actually go through mdoc, but I don't think it's necessary. The design pages are more like blogposts, which are often difficult to mdoc-ify because we keep rewriting some definitions.

@kubukoz kubukoz merged commit d7afe21 into disneystreaming:series/0.18 May 18, 2024
11 checks passed
@lenguyenthanh lenguyenthanh deleted the patch-1 branch May 19, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants