Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customize sbt opts #1551

Merged

Conversation

lenguyenthanh
Copy link
Contributor

@lenguyenthanh lenguyenthanh commented May 29, 2024

This probably unnecessary, but sbt always crash on my machine with the current .sbtopts. I have to increase max memory to 16G (can be less but 6G is not enough).

@Baccata
Copy link
Contributor

Baccata commented May 29, 2024

Mmm, I'm not against adding .sbtopts to .gitignore and removing the existing file, but I'd rather we used top-level environment variables in the ci-workflow than having a step copying the sbtopts file.

@kubukoz
Copy link
Member

kubukoz commented May 29, 2024

I don't have a strong opinion, but personally I've been passing -J-Xmx16g explicitly for my local usage.

@lenguyenthanh
Copy link
Contributor Author

added

env:
  SBT_MAX_HEAP_SIZE: 6G # Max heap size for sbt

and use it every where

@Baccata
Copy link
Contributor

Baccata commented May 30, 2024

@lenguyenthanh sorry for the churn, but I actually meant using the SBT_OPTS environment variable, to avoid repeating the change in many steps. See here : https://www.scala-sbt.org/1.x/docs/Command-Line-Reference.html#sbt+JVM+options+and+system+properties

@lenguyenthanh
Copy link
Contributor Author

no problem, I'll update it, when I can reach my computer.

@lenguyenthanh lenguyenthanh force-pushed the allow-customize-sbt-opts branch 2 times, most recently from 4f375c6 to 3f3ed6e Compare May 31, 2024 05:47
@lenguyenthanh lenguyenthanh force-pushed the allow-customize-sbt-opts branch from 3f3ed6e to db3cd93 Compare May 31, 2024 05:50
@lenguyenthanh
Copy link
Contributor Author

added SBT_OPTS env variables with the same values as .sbtopts.example.

@Baccata Baccata merged commit d40e0f5 into disneystreaming:series/0.18 May 31, 2024
11 checks passed
@Baccata
Copy link
Contributor

Baccata commented May 31, 2024

Thank you !

@lenguyenthanh lenguyenthanh deleted the allow-customize-sbt-opts branch June 1, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants