Use protoc from nix when available #1558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghostbuster91
commented
Jun 4, 2024
ghostbuster91
commented
Jun 11, 2024
| "nodejs-16_x" | ||
| "yarn" | ||
| shellPackages = with pkgs; [ | ||
| temurin-jre-bin-17 |
There was a problem hiding this comment.
thought: I replaced default jre with the same one that is used on the CI
ghostbuster91
commented
Jun 11, 2024
| temurin-jre-bin-17 | ||
| nodejs-18_x | ||
| yarn | ||
| (pkgs.sbt.override { jre = pkgs.temurin-jre-bin-17; }) |
There was a problem hiding this comment.
thought: I had to override the jre version used by this particular derivation of sbt (which is still 1.8.x version) as it was using too recent version of jre - 21.
I then decided to completely drop the idea of shellInputs being just a list of strings since this required the packages to be defined in two places without any particular benefit. Also the errors from nix evaluator were harder to debug when using strings.
kubukoz
reviewed
Jun 11, 2024
Co-authored-by: Jakub Kozłowski <kubukoz@gmail.com>
ghostbuster91
commented
Jun 11, 2024
kubukoz
approved these changes
Jun 13, 2024
kubukoz
reviewed
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist (not all items are relevant to all PRs)