Ensure hint are set and used for validation of union #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daddykotex
commented
Apr 14, 2022
| expect(result == CheckedOrUnchecked.CheckedCase(CheckedString("foo"))) | ||
| } | ||
|
|
||
| pureTest("Invalid union values fails to parse") { |
There was a problem hiding this comment.
I'm not 100% sure I understand the issue because, in bad TDD fashion, I wrote the test after, then checked if the test failed before my fix, but it does not.
to be clear, the test passes w/o the fix, so I'm not sure if it does anything
There was a problem hiding this comment.
Try moving the constraint from the string shape to one of the alternatives in the union definition in smithy (similarly to how you'd annotate fields in structure shapes)
There was a problem hiding this comment.
got it, the issue happens if the annotation is placed directly on a member of the union, the fixes works
|
Superseded by #186 |
|
Oh well... I forgot to push my changes after your advice. I'm sorry lollll
…On Fri., Apr. 15, 2022, 04:10 Olivier Mélois, ***@***.***> wrote:
Closed #185 <#185>.
—
Reply to this email directly, view it on GitHub
<#185 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABH467FUCJ6SONL76ENML4TVFEP6HANCNFSM5TO2ON5A>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
No worries |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.