Pull dependencies rather than scanning the build classpath #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baccata
reviewed
Apr 23, 2022
| ) | ||
| .settings( | ||
| libraryDependencies += Dependencies.Smithy.model, | ||
| javacOptions ++= Seq("--release", "8") |
There was a problem hiding this comment.
👍, but we might want Xlint still
There was a problem hiding this comment.
at least, in the JVM 11, javac -Xlint did not seem to be a thing
Baccata
added a commit
that referenced
this pull request
May 10, 2022
Pull dependencies rather than scanning the build classpath
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR:
protocola java lib (move test in another module)If you have jars in your sbt classpath that contains smithy files, the content is taken into account and codegen will produce code accordingly.
In some context, users can be completely unaware that they're pulling such dependencies and may not understand why codegen has produced such code.
In other scenario, it straight up break the build because the generated code conflict with some stuff already on the classpath.
We avoid the issue here by using explicit dependency on :
protocol(local project) andsmithy-model.We have to make sure that
protocolis published locally for all jvm version before running the codegen scripted tests.