Rendering interpolator #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # modules/codegen/src/smithy4s/codegen/Renderer.scala
|
yunion seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Closed
daddykotex
approved these changes
May 10, 2022
build.sbt
Outdated
| @@ -295,8 +295,9 @@ lazy val codegen = projectMatrix | |||
| Dependencies.Weaver.cats.value % Test | |||
| ), | |||
| testFrameworks += new TestFramework("weaver.framework.CatsEffect"), | |||
| scalacOptions := scalacOptions.value | |||
| scalacOptions := scalacOptions.value | |||
| case Primitive.ByteArray => Line(Set("smithy4s.ByteArray"), "ByteArray") | ||
| case Primitive.Bool => line"Boolean" | ||
| case Primitive.String => line"String" | ||
| case Primitive.Timestamp => line"smithy4s.Timestamp" |
There was a problem hiding this comment.
don't we need the Line(Set("smithy4s.Timestamp"), "Timestamp") syntax here? and on like 71 too?
…hod, as its not needed in that file
type ascription will just be Timestamp and Document ,this results in a code chamnge in example ArbitraryData
Baccata
commented
May 11, 2022
|
good work @yisraelU ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworks the rendering logic to make use of a custom string-interpolator that allows to gather imports in an interpolated fashion.
In addition, renames a few constructs with more intuitive semantics.