Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recursively return all the generated files #215

Merged
merged 2 commits into from
May 16, 2022
Merged

Conversation

keynmol
Copy link
Contributor

@keynmol keynmol commented May 14, 2022

Use FileFunction mechanism to more accurately cache the input and output files of the task, as well as react to file changes for more interactive experience.

This combination seems to remove the issues I was seeing before with Zinc.

@keynmol
Copy link
Contributor Author

keynmol commented May 14, 2022

I think this needs a bit more work, as I'm getting

[error] 6 |import smithy4s.syntax._
[error]   |       ^^^^^^^^^^^^^^^
[error]   |       value syntax is not a member of smithy4s

occasionally when modifying a broken compilation unit..

@keynmol keynmol force-pushed the fix-codegen-plugin branch from 14eb238 to 780cb3c Compare May 15, 2022 12:05
@Baccata
Copy link
Contributor

Baccata commented May 16, 2022

@keynmol is this ready ?

@keynmol
Copy link
Contributor Author

keynmol commented May 16, 2022

I believe so, yes.
It's better than what's currently in main, so that's 1 reason to merge it :)

@Baccata Baccata merged commit 7f31df8 into main May 16, 2022
@Baccata Baccata deleted the fix-codegen-plugin branch May 16, 2022 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants