Use FQNs in rendered Product and Serializable inheritance
#63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubukoz
reviewed
Jan 21, 2022
| @@ -460,7 +460,7 @@ private[codegen] class Renderer(compilationUnit: CompilationUnit) { self => | |||
| values: List[EnumValue], | |||
| hints: List[Hint] | |||
| ): RenderResult = lines( | |||
| s"sealed abstract class $name(val value: String, val ordinal: Int) extends Product with Serializable", | |||
| s"sealed abstract class $name(val value: String, val ordinal: Int) extends scala.Product with scala.Serializable", | |||
There was a problem hiding this comment.
general thought, should we do the same for collections? I imagine a type like Vector might appear in users' smithy files
There was a problem hiding this comment.
I don't think that should be default behaviour, but maybe we'll add that as an option to the rendering
kubukoz
approved these changes
Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using full-qualified-names because users encounter issues when they use
Productas a shape name.