[0.18] Remove CE2 support #865
Conversation
Baccata
requested review from
daddykotex and
kubukoz
and removed request for
daddykotex
There was a problem hiding this comment.
Imagine the ratio of deleted lines if you had not added all those copyright headers!
Great PR, definitely will alleviate some of the pains in the build tool and the IDE.
Unrelated, but could we consider date less copy right headers, so we would not need to update them continuously (some are outdated here I guess)
I thought the date was a legal requirement . Any information suggesting it ain't ? Worst case scenario, we can update the date programmatically using the current year (in another PR of course) |
I was inspired by this: smithy-lang/smithy#1614 |
why do I feel like every other PR adds these. aren't we checking for headers in CI? :D |
| @@ -44,7 +46,7 @@ private[compliancetests] class ClientHttpComplianceTestCase[ | |||
| ]( | |||
| reverseRouter: ReverseRouter[F], | |||
| serviceInstance: Service[Alg] | |||
| )(implicit ce: CompatEffect[F]) { | |||
| )(implicit ce: Async[F]) { | |||
There was a problem hiding this comment.
suggestion: this can be loosened to Temporal. Probably a couple other spots where we can loosen the constraints too.
project/Dependencies.scala
Outdated
|
|
||
| object Http4s { | ||
| val http4sVersion = Def.setting(if (isCE3.value) "0.23.18" else "0.22.15") | ||
| val http4sVersion = Def.setting("0.23.17") |
There was a problem hiding this comment.
You can drop the Def.setting now.
project/Dependencies.scala
Outdated
| @@ -112,7 +111,7 @@ object Dependencies { | |||
|
|
|||
| object Weaver { | |||
|
|
|||
| val weaverVersion = Def.setting(if (isCE3.value) "0.8.1" else "0.6.15") | |||
| val weaverVersion = Def.setting("0.8.1") | |||
|
(assuming CI likes it) |
Removes support for cats-effect-2