Upgrade libraries, Scala.js and Scala 3 #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also bring in the macrotask dependency for Scala.js
This was referenced Jul 6, 2022
keynmol
commented
Jul 6, 2022
|
|
||
| import org.scalajs.macrotaskexecutor.MacrotaskExecutor | ||
|
|
||
| private[weaver] object PlatformECCompat { |
There was a problem hiding this comment.
Fun fact - naming is important.
This used to be trait PlatformCompat - but then it crashed the Scala 2 compiler, saying superclass is invalid.
When I changed it to object PlatformCompat, it broke Scala.js linker.
So there. "fun" fact
|
Thanks a LOT for this, after the wave of upgrades, I figured I'd have to add it to my ever growing TODO list. Really glad I don't have to. |
Baccata
approved these changes
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also bring in the macrotask dependency for Scala.js
I don't think the decision to bump Scala to 3.1.x is controversial anymore - Cats did it in 2.8.0, 20 days ago.
This helps clear out the path of upgrades to the great schism (#481), giving us a sort of cleanish slate.
I couldn't do
zio 2.5.1.0 -> 2.5.1.1because I got 59 compilation errors and... yeah.If this goes green, I'll just close all the individual steward PRs and iterate here instead.
Closes #476