Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update versions #606

Merged
merged 1 commit into from
Nov 15, 2022
Merged

Update versions #606

merged 1 commit into from
Nov 15, 2022

Conversation

Baccata
Copy link
Contributor

@Baccata Baccata commented Nov 15, 2022

No description provided.

@keynmol
Copy link
Collaborator

keynmol commented Nov 15, 2022

Just 1 comment, even though you know my position on upgrades - TEAM UPGRADE YO.

The only reason people need to upgrade to CE3.4. is to re-enable Graalvm Native Image on Scala 3 - hence the bump to 3.2.x, as it needs entirely new bytecode.

We as testing framework don't need to upgrade, but we still can. Thought I wonder if we should wait for a little bit for 3.4.0 to propagate first?

@Baccata
Copy link
Contributor Author

Baccata commented Nov 15, 2022

We as testing framework don't need to upgrade, but we still can.

Asking ourselves that question contributes to the maintenance burden. We're not promising any LTS on any of the (non-LTS) Scala 3 minor releases, and I can't really be bothered with delaying upgrades out of concern for the handful of Scala 3 users who are on non-LTS versions (the future 3.3 being the first planned LTS, afaik).

Do you have a non-hypothetical case to point to, that would be impacted by these bumps ? (my point of view might change if you do).

@keynmol
Copy link
Collaborator

keynmol commented Nov 15, 2022

Nah, I wasn't really even trying to block this upgrade - just wanted to spell out the possible reasons not to upgrade.

I think with dispatcher deprecations in CE 3.4 this upgrade will fail the build if the users are using strict flags, but they can always rollback.

So all 🟢 on my side.

@Baccata
Copy link
Contributor Author

Baccata commented Nov 15, 2022

but they can always rollback.

Yup that's my thinking too

@Baccata Baccata merged commit 1ef15bf into main Nov 15, 2022
@Baccata Baccata deleted the version-updates branch November 15, 2022 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants