Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Co2 parameter ppm should be int #107

Merged
merged 1 commit into from
May 19, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions disruptive/events/events.py
Original file line number Diff line number Diff line change
Expand Up @@ -1567,23 +1567,23 @@ class Co2(_EventData):

Attributes
----------
ppm : float
ppm : int
Co2 concentration in parts per million.
timestamp : datetime
Timestamp of when the event was received by a Cloud Connector.

"""

def __init__(self,
ppm: float,
ppm: int,
timestamp: Optional[datetime | str] = None,
) -> None:
"""
Constructs the Co2 object.

Parameters
----------
ppm : float
ppm : int
Co2 concentration in parts per million.
timestamp : datetime, str, optional
Timestamp in either datetime or string iso8601 format
Expand All @@ -1592,7 +1592,7 @@ def __init__(self,
"""

# Set parameter attributes.
self.ppm: float = ppm
self.ppm: int = ppm
self.timestamp: Optional[datetime | str] = timestamp

# Inherit parent _EventData class init with repacked data dictionary.
Expand Down