Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support table concept in core module #155

Merged
merged 47 commits into from
Sep 26, 2019
Merged

Support table concept in core module #155

merged 47 commits into from
Sep 26, 2019

Conversation

senyer
Copy link
Collaborator

@senyer senyer commented Sep 2, 2019

  1. Design table concept structure
  2. implements createTable()
  3. implements append() //TODO：need to improve
  4. implements getTableByName()
  5. implements query() //TODO：need to improve
  6. implements drop()
  7. implements verifyLegitimacy()
  8. implements clearTable()
  9. implements clear()

senyer and others added 29 commits August 18, 2019 16:29
@senyer
support dst-list
d9f1d15
@senyer
fix test faliure
ea1f0c0
@senyer
support list rpc implements
d8fafc1
@senyer
Merge branch 'master' into master
bb23b8b
@senyer
enhance test module,
f38aaec 
Reduce duplicate code
@senyer
Merge remote-tracking branch 'origin/master'
019df18
@senyer
Merge branch 'master' into master
5b49e5b
@senyer
Merge branch 'master' of github.com:dst-project/dst
07fa1c5 
# Conflicts:
#	server/src/main/java/org/dst/server/service/DstListServiceImpl.java
#	server/src/main/proto/list_pb.proto
#	test/src/test/java/test/org/dst/core/KVStoreTest.java
#	test/src/test/java/test/org/dst/core/operator/KVSListTest.java
@senyer
fix
3946e48
@senyer
Merge branch 'master' of github.com:dst-project/dst
f188f45
@senyer
Merge remote-tracking branch 'origin/master'
c2477f1 
# Conflicts:
#	test/src/test/java/test/org/dst/core/KVStoreTest.java
@senyer
Merge branch 'master' of github.com:dst-project/dst
459fe9e
@senyer
Merge remote-tracking branch 'origin/master'
e6f5052
@senyer
Merge branch 'master' of github.com:dst-project/dst
26fb3b7
@senyer
Merge branch 'master' of github.com:senyer/dst
ea16d28
@senyer
Merge branch 'master' of github.com:dst-project/dst
1c8fb81
@senyer
Merge branch 'master' of github.com:dst-project/dst
b06c1be
@senyer
merge Merge branch 'master' of github.com:senyer/dst
e624430
@senyer
Merge branch 'master' of github.com:dst-project/dst
732bacc 
ok
@senyer
mergeMerge branch 'master' of github.com:dst-project/dst
7cf215b
@senyer
Merge branch 'master' of github.com:dst-project/dst
bf80989
@senyer
support table concept
94a53f3
@senyer
fix logback.xml
9c86f58
@senyer
improve core table
e485d03
@senyer
Merge branch 'master' of github.com:dst-project/dst into core_table
8c444e0
@senyer
improve core table
4da2e0f
@senyer
improve core table
12889e5
@senyer
support core table
a3c44b6
@senyer
support core table
d34af27
jovany-wang
jovany-wang requested changes Sep 7, 2019
View reviewed changes
Copy link
Collaborator

@jovany-wang jovany-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Add comments for you public class to explain about more details of the classes, like some exception classes.

common/src/main/java/org/dst/exception/IncorrectRecordFormatException.java Outdated Show resolved Hide resolved
common/src/main/java/org/dst/exception/IncorrectRecordFormatException.java Outdated Show resolved Hide resolved
common/src/main/java/org/dst/exception/IncorrectRecordFormatException.java Outdated Show resolved Hide resolved
common/src/main/java/org/dst/exception/IncorrectRecordFormatException.java Outdated Show resolved Hide resolved
common/src/main/java/org/dst/exception/PrimaryKeyNotUniqueException.java Outdated Show resolved Hide resolved
@jovany-wang jovany-wang self-assigned this Sep 8, 2019
@jovany-wang jovany-wang changed the title Support Core table Support table concept in core module Sep 8, 2019
jovany-wang
jovany-wang requested changes Sep 18, 2019
View reviewed changes
common/src/main/java/org/dst/exception/DuplicatedPrimaryKeyException.java Outdated Show resolved Hide resolved
common/src/main/java/org/dst/exception/IncorrectRecordFormatException.java Outdated Show resolved Hide resolved
common/src/main/java/org/dst/exception/IncorrectTableFormatException.java Outdated Show resolved Hide resolved
common/src/main/java/org/dst/exception/RepeatCreateTableException.java Outdated Show resolved Hide resolved
common/src/main/java/org/dst/exception/TableNotFoundException.java Outdated Show resolved Hide resolved
core/src/main/java/org/dst/core/operatorImpl/DstTableImpl.java Outdated Show resolved Hide resolved
core/src/main/java/org/dst/core/table/Value.java Outdated Show resolved Hide resolved
core/src/main/java/org/dst/core/table/Field.java

private boolean index = false;

public Field() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we need this ctor?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If not explicitly declared ,we can't use this structure function

core/src/main/java/org/dst/core/table/Field.java Outdated Show resolved Hide resolved
jovany-wang
jovany-wang requested changes Sep 19, 2019
View reviewed changes
Copy link
Collaborator

@jovany-wang jovany-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments about the doc comments. Please also address other comments.

core/src/main/java/org/dst/core/operatorset/DstTable.java Outdated Show resolved Hide resolved
core/src/main/java/org/dst/core/operatorset/DstTable.java Outdated Show resolved Hide resolved
core/src/main/java/org/dst/core/operatorset/DstTable.java Outdated Show resolved Hide resolved
core/src/main/java/org/dst/core/operatorset/DstTable.java Outdated Show resolved Hide resolved
core/src/main/java/org/dst/core/operatorset/DstTable.java Outdated Show resolved Hide resolved
senyer and others added 3 commits September 21, 2019 08:22
@senyer
code_adj
b3d1ef7
@senyer
Merge branch 'master' of github.com:dst-project/dst into server_table
cc0c989 
# Conflicts:
#	common/src/main/java/org/dst/common/protobuf/common_pb.proto
#	core/src/main/java/org/dst/core/operatorImpl/DstTableImpl.java
@jovany-wang
Merge branch 'master' into core_table
3d21596
jovany-wang
jovany-wang requested changes Sep 21, 2019
View reviewed changes
core/src/main/java/org/dst/core/operatorset/DstTable.java Outdated Show resolved Hide resolved
common/src/main/java/org/dst/common/exception/DuplicatedPrimaryKeyException.java Outdated Show resolved Hide resolved
core/src/main/java/org/dst/core/operatorset/DstTable.java Outdated Show resolved Hide resolved
core/src/main/java/org/dst/core/operatorset/DstTable.java Outdated Show resolved Hide resolved
core/src/main/java/org/dst/core/operatorset/DstTable.java Outdated Show resolved Hide resolved
core/src/main/java/org/dst/core/operatorImpl/DstTableImpl.java Outdated Show resolved Hide resolved
core/src/main/java/org/dst/core/operatorImpl/DstTableImpl.java Outdated Show resolved Hide resolved
core/src/main/java/org/dst/core/operatorImpl/DstTableImpl.java Outdated Show resolved Hide resolved
core/src/main/java/org/dst/core/operatorImpl/DstTableImpl.java Outdated Show resolved Hide resolved
core/src/main/java/org/dst/core/operatorImpl/DstTableImpl.java Outdated Show resolved Hide resolved
jovany-wang
jovany-wang approved these changes Sep 26, 2019
View reviewed changes
Copy link
Collaborator

@jovany-wang jovany-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good to me now. Nice job!

@jovany-wang jovany-wang merged commit 62f8767 into distkv-project:master Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jovany-wang jovany-wang jovany-wang approved these changes

Assignees

@jovany-wang jovany-wang

Labels
table
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@senyer @jovany-wang