Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the semantics of list.get #260

Merged
merged 8 commits into from
Nov 13, 2019
Merged

Refactor the semantics of list.get #260

merged 8 commits into from
Nov 13, 2019

Conversation

jovany-wang
Copy link
Collaborator

@jovany-wang jovany-wang commented Nov 12, 2019 •
edited
Loading

This PR is the part of supporting completed list.get semantics:

list.get key [index / from end]
  1. Get all values of the key:
list.get key
  1. Get the specific value of the given index from the list.
list.get key index
  1. Get the values of the given range from the list:
list.get key from end

@jovany-wang jovany-wang changed the title [WIP] Refine list concept parser Refine list concept parser Nov 13, 2019
@jovany-wang jovany-wang changed the title Refine list concept parser Refactor the semantics of list.get Nov 13, 2019
@jovany-wang jovany-wang added the enhancement enhancement label Nov 13, 2019
@jovany-wang jovany-wang merged commit 3a4fb02 into distkv-project:master Nov 13, 2019
@jovany-wang jovany-wang deleted the refine_sql branch November 13, 2019 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@senyer senyer Awaiting requested review from senyer

@MrKingHH MrKingHH Awaiting requested review from MrKingHH

@kairbon kairbon Awaiting requested review from kairbon

Assignees
No one assigned
Labels
enhancement enhancement feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jovany-wang