Implement DstSortedListLinkedImpl for sorted list #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 22, 2019 12:05
ou-taku14
changed the title
added 14 commits
December 24, 2019 22:15
ou-taku14
changed the title
senyer
reviewed
Dec 29, 2019
common/src/main/java/com/distkv/dst/common/exception/SortedListDuplicatedMembersException.java
Outdated
Show resolved
Hide resolved
common/src/main/java/com/distkv/dst/common/exception/SortedListDuplicatedMembersException.java
Outdated
Show resolved
Hide resolved
common/src/main/java/com/distkv/dst/common/exception/SortedListIncrScoreOutOfRange.java
Outdated
Show resolved
Hide resolved
jovany-wang
requested changes
Dec 29, 2019
common/src/main/java/com/distkv/dst/common/entity/sortedList/SortedListEntity.java
Show resolved
Hide resolved
common/src/main/java/com/distkv/dst/common/exception/SortedListDuplicatedMembersException.java
Outdated
Show resolved
Hide resolved
common/src/main/java/com/distkv/dst/common/exception/SortedListDuplicatedMembersException.java
Outdated
Show resolved
Hide resolved
common/src/main/java/com/distkv/dst/common/exception/SortedListIncrScoreOutOfRange.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/distkv/dst/core/concepts/DstSortedListsImpl.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/distkv/dst/core/concepts/DstSortedListsImpl.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/distkv/dst/core/struct/slist/SortedList.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/distkv/dst/core/struct/slist/SortedListLinkedListImpl.java
Outdated
Show resolved
Hide resolved
senyer
approved these changes
Jan 5, 2020
core/src/main/java/com/distkv/dst/core/struct/slist/SortedList.java
Outdated
Show resolved
Hide resolved
jovany-wang
requested changes
Jan 6, 2020
client/src/main/java/com/distkv/dst/client/CheckStatusUtil.java
Outdated
Show resolved
Hide resolved
|
Could you add the descriptor in this PR? |
jovany-wang
reviewed
Jan 6, 2020
...test/java/com/distkv/dst/test/benchmark/core/concepts/DstSortedListsImplSimpleBenchmark.java
Show resolved
Hide resolved
server/src/main/java/com/distkv/dst/server/runtime/workerpool/Worker.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/distkv/dst/core/struct/slist/SortedList.java
Outdated
Show resolved
Hide resolved
added 2 commits
January 7, 2020 20:39
This comment has been minimized.
This comment has been minimized.
Like |
jovany-wang
approved these changes
Jan 9, 2020
jovany-wang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test environment:
The above is the LinkedList implementation of the Dst SortedList. There is the benchmark in my machine.
(Description: My benchmark program is to test a SortedList with a maximum length of 1000000 which value is DstSortedListsImplSimpleBenchmark.lengthInPutList over the average time of 10 tests. You can modify the member variable maxOperationtimes which represents the number of tests for each operation. In the benchmark results, Magnitude represents the maximum length. Total time represents the sum of the nanosecond taken to perform this operation. Average time is the average time for this operation. )